Fix the bug that user may logout if GetUserByID return unknow error #29964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a#29962) This PR fixed a bug when the user switching pages too fast, he will logout automatically. The reason is that when the error is context cancelled, the previous code think user hasn't login then the session will be deleted. Now it will return the errors but not think it's not login. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wolfogre
approved these changes
Mar 21, 2024
GiteaBot
added
lgtm/need 1
|
I do not think it needs to be backported. Becaseu 1.21 uses |
wxiaoguang
added
the
lgtm/blocked
But it may return other errors like temporary network problems between Gitea and database. Should the user be logout because of that reason? |
wxiaoguang
removed
the
lgtm/blocked
|
Then the title/description/comment don't match |
lunny
changed the title
Updated. |
wxiaoguang
approved these changes
Mar 21, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
delvh
approved these changes
Mar 21, 2024
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #29962
This PR fixed a bug when the user switching pages too fast, he will logout automatically.
The reason is that when the error is context cancelled, the previous code think user hasn't login then the session will be deleted. Now it will return the errors but not think it's not login.