Fix uploaded artifacts should be overwritten (#28726) #28821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `Uploaded artifacts should be overwritten` go-gitea#28549 When upload different content to uploaded artifact, it checks that content size is not match in db record with previous artifact size, then the new artifact is refused. Now if it finds uploading content size is not matching db record when receiving chunks, it updates db records to follow the latest size value.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
lunny
approved these changes
Jan 17, 2024
GiteaBot
added
lgtm/need 1
|
@fuxiaohei please have a look, looks it can't be built in v1.21. |
|
replaced by #28832 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #28726 by @fuxiaohei
Fix
Uploaded artifacts should be overwritten#28549When upload different content to uploaded artifact, it checks that content size is not match in db record with previous artifact size, then the new artifact is refused.
Now if it finds uploading content size is not matching db record when receiving chunks, it updates db records to follow the latest size value.