Upgrade go git

[lunny]

Upgrade github.com/go-git/go-git/v5 from v5.9.0 -> v5.11.0

[wxiaoguang]

Unfortunately, ref #28518

BUT

[techknowlogick]

CI fail seems related

[harryzcy]

It seems to be the issue with go-git. I can get the commit using git cat-file -p <sha>, but go-git gives object not found

Maybe go-git is not reading objects/info/alternates correctly, when the file structure is the following:

.
├── branches
├── config
├── description
├── HEAD
├── hooks
│   ├── applypatch-msg.sample
│   ├── commit-msg.sample
│   ├── fsmonitor-watchman.sample
│   ├── post-update.sample
│   ├── pre-applypatch.sample
│   ├── pre-commit.sample
│   ├── pre-merge-commit.sample
│   ├── prepare-commit-msg.sample
│   ├── pre-push.sample
│   ├── pre-rebase.sample
│   ├── pre-receive.sample
│   ├── push-to-checkout.sample
│   └── update.sample
├── index
├── info
│   └── exclude
├── logs
│   └── HEAD
├── objects
│   ├── info
│   │   └── alternates
│   └── pack
├── packed-refs
└── refs
    ├── heads
    └── tags

[lunny]

It seems to be the issue with go-git. I can get the commit using git cat-file -p <sha>, but go-git gives object not found

Maybe go-git is not reading objects/info/alternates correctly, when the file structure is the following:

.
├── branches
├── config
├── description
├── HEAD
├── hooks
│   ├── applypatch-msg.sample
│   ├── commit-msg.sample
│   ├── fsmonitor-watchman.sample
│   ├── post-update.sample
│   ├── pre-applypatch.sample
│   ├── pre-commit.sample
│   ├── pre-merge-commit.sample
│   ├── prepare-commit-msg.sample
│   ├── pre-push.sample
│   ├── pre-rebase.sample
│   ├── pre-receive.sample
│   ├── push-to-checkout.sample
│   └── update.sample
├── index
├── info
│   └── exclude
├── logs
│   └── HEAD
├── objects
│   ├── info
│   │   └── alternates
│   └── pack
├── packed-refs
└── refs
    ├── heads
    └── tags

Can you send this issue to upstream?

[harryzcy]

Can you send this issue to upstream?

Done go-git/go-git#1002

[pjbgf]

If altPath is relative to the host root dir, you probably want:
options.AlternatesFS = osfs.New("/")

I think this might work as well:
options.AlternatesFS = osfs.New(altPath, osfs.WithBoundOS())

[lunny]

Thanks! Changed in 4f26e65, but it seems I'm still not lucky.
Does this work in Windows?

options.AlternatesFS = osfs.New("/")

[pjbgf]

My understanding is that osfs.New("") and osfs.New("/") are equivalent. But looking across go-git, we seem to only use the former - for example on the default loader.

[wxiaoguang]

FYI: osfs.New("") is not the same as osfs.New("/")

And I think there are some other problems in go-git: go-git/go-git#1006

[lunny]

replaced by #28893