Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong link in protect_branch_name_pattern_desc (#28313) #28315

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix wrong link in protect_branch_name_pattern_desc (#28313) #28315

merged 1 commit into from
Dec 1, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Dec 1, 2023

Backport #28313 by @yp05327

The current href will link to https://domain/owner/repo/settings/branches/github.com/gobwas/glob

@yp05327 @GiteaBot
Fix wrong link in protect_branch_name_pattern_desc (go-gitea#28313)
7d1b002 
The current href will link to
`https://domain/owner/repo/settings/branches/github.com/gobwas/glob`
@GiteaBot GiteaBot added this to the 1.21.2 milestone Dec 1, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 1, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2023
delvh
delvh approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the translations in 1.21?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 1, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 1, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 1, 2023
@lunny lunny merged commit fee9c05 into go-gitea:release/v1.21 Dec 1, 2023
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 1, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

@lng2020 lng2020 Awaiting requested review from lng2020

Assignees

@yp05327 yp05327

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.21.2
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @delvh @yp05327