Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "is-loading" to avoid duplicate form submit for code comment #28143

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 20, 2023

Compare by ignoring spaces: https://github.com/go-gitea/gitea/pull/28143/files?diff=split&w=1

When the form is going to be submitted, add the "is-loading" class to show an indicator and avoid user UI events.

When the request finishes (success / error), remove the "is-loading" class to make user can interact the UI.

@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Nov 20, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 20, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2023
@wxiaoguang wxiaoguang added backport/v1.21 This PR should be backported to Gitea 1.21 and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) November 21, 2023 02:08
@wxiaoguang wxiaoguang merged commit 247927a into go-gitea:main Nov 21, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2023
@wxiaoguang wxiaoguang deleted the fix-comment-submit branch November 21, 2023 02:18
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 21, 2023
…gitea#28143)

When the form is going to be submitted, add the "is-loading" class to
show an indicator and avoid user UI events.

When the request finishes (success / error), remove the "is-loading"
class to make user can interact the UI.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 21, 2023
lunny pushed a commit that referenced this pull request Nov 21, 2023
) (#28147)

Backport #28143 by @wxiaoguang

Compare by ignoring spaces:
https://github.com/go-gitea/gitea/pull/28143/files?diff=split&w=1

When the form is going to be submitted, add the "is-loading" class to
show an indicator and avoid user UI events.

When the request finishes (success / error), remove the "is-loading"
class to make user can interact the UI.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind pushed a commit to silverwind/gitea that referenced this pull request Nov 21, 2023
…gitea#28143)

When the form is going to be submitted, add the "is-loading" class to
show an indicator and avoid user UI events.

When the request finishes (success / error), remove the "is-loading"
class to make user can interact the UI.
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2023
* giteaofficial/main:
  Fix the description about the default setting for action in quick start document (go-gitea#28160)
  Do not display search box when there's no packages yet (go-gitea#28146)
  Add guide page to actions when there's no workflows (go-gitea#28145)
  Fix no ActionTaskOutput table waring (go-gitea#28149)
  Fix empty action run title (go-gitea#28113)
  Use "is-loading" to avoid duplicate form submit for code comment (go-gitea#28143)
  Fix typo in `packages.cleanup.success` (go-gitea#28133)
  Add edit option for README.md (go-gitea#28071)
  Remove autofocus in search box (go-gitea#28033)
  Add missing `packages.cleanup.success` (go-gitea#28129)
  Update docs for docusaurus v3 (go-gitea#28125)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
…gitea#28143)

When the form is going to be submitted, add the "is-loading" class to
show an indicator and avoid user UI events.

When the request finishes (success / error), remove the "is-loading"
class to make user can interact the UI.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants