Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document REACTION_MAX_USER_NUM setting option #27954

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Document REACTION_MAX_USER_NUM setting option #27954

merged 3 commits into from
Nov 8, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 7, 2023 •
edited
Loading

gitea/modules/setting/ui.go

Line 24 in 4a0103f

ReactionMaxUserNum int

gitea/modules/setting/ui.go

Line 77 in 4a0103f

ReactionMaxUserNum: 10,

Sponsored by Kithara Software GmbH

@6543 6543 added the type/docs This PR mainly updates/creates documentation label Nov 7, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 7, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 7, 2023
@techknowlogick techknowlogick added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.21 This PR should be backported to Gitea 1.21 and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 7, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 7, 2023
6543
6543 commented Nov 7, 2023
View reviewed changes
custom/conf/app.example.ini Outdated Show resolved Hide resolved
docs/content/administration/config-cheat-sheet.en-us.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 7, 2023
@silverwind
Copy link
Member

Why don't I find this string REACTION_MAX_USER_NUM anywhere in the code base?

@delvh delvh added the lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged label Nov 7, 2023
@6543
Copy link
Member Author

6543 commented Nov 8, 2023

gitea/modules/setting/ui.go

Line 24 in 4a0103f

ReactionMaxUserNum int

gitea/modules/setting/ui.go

Line 77 in 4a0103f

ReactionMaxUserNum: 10,

@silverwind

@6543 6543 removed the lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged label Nov 8, 2023
@6543 6543 merged commit 8ef169a into go-gitea:main Nov 8, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 8, 2023
@6543 6543 deleted the docu_REACTION_MAX_USER_NUM branch November 8, 2023 00:50
@GiteaBot GiteaBot mentioned this pull request Nov 8, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 8, 2023
@6543 @GiteaBot
Document REACTION_MAX_USER_NUM setting option (go-gitea#27954)
541fa67 
https://github.com/go-gitea/gitea/blob/4a0103fa293cc42075d4a9c10ca4dffa9c2d3a40/modules/setting/ui.go#L24

https://github.com/go-gitea/gitea/blob/4a0103fa293cc42075d4a9c10ca4dffa9c2d3a40/modules/setting/ui.go#L77

---
*Sponsored by Kithara Software GmbH*
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 8, 2023
lunny pushed a commit that referenced this pull request Nov 8, 2023
@GiteaBot @6543
Document REACTION_MAX_USER_NUM setting option (#27954) (#27959)
cc7b9eb 
Backport #27954 by @6543

as title

---
*Sponsored by Kithara Software GmbH*

Co-authored-by: 6543 <m.huber@kithara.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 8, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
cf839bf 
* giteaofficial/main:
  Fix citation error when the file size is larger than 1024 bytes (go-gitea#27958)
  Use flex-container on user dashboard (go-gitea#27956)
  Document REACTION_MAX_USER_NUM setting option (go-gitea#27954)
  Add word-break to repo description in home page (go-gitea#27924)
  Remove go versions from .golangci.yml (go-gitea#27953)
  Fix the overflow style for "Hide all checks" (go-gitea#27932)
  Fix rendering assignee changed comments without assignee (go-gitea#27927)
  Add word break to release title (go-gitea#27942)
@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 8, 2023

@silverwind You only see the names if the value needs special handling. Otherwise it's just the naming convention for auto-mapping.

@silverwind
Copy link
Member

Imho dis case convertion should be removed to make these values greppable.

@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 8, 2023

But it's the default. You would not read json into a map[string]any and map the fields manually just to make the key names greppable.

@silverwind
Copy link
Member

silverwind commented Nov 8, 2023 •
edited
Loading

Bad default. Nothing prevents us from having MACRO_CASE as struct key. I do it in other applications as well. Greppability > Variable name conventions :)

@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 8, 2023

Ah, you talk about the field names in the settings structs.

fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@6543 @fuxiaohei
Document REACTION_MAX_USER_NUM setting option (go-gitea#27954)
e467fde 
https://github.com/go-gitea/gitea/blob/4a0103fa293cc42075d4a9c10ca4dffa9c2d3a40/modules/setting/ui.go#L24

https://github.com/go-gitea/gitea/blob/4a0103fa293cc42075d4a9c10ca4dffa9c2d3a40/modules/setting/ui.go#L77

---
*Sponsored by Kithara Software GmbH*
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebastian-sauer sebastian-sauer sebastian-sauer left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @silverwind @KN4CK3R @techknowlogick @sebastian-sauer @GiteaBot @delvh