Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about attachment path #26883

Merged

Conversation

CaiCandong
Copy link
Member

@CaiCandong CaiCandong commented Sep 3, 2023

This change was caused by #26271, for configuration as below:

[attachment]
ENABLE = true
PATH = data/attachments
MAX_SIZE = 100
MAX_FILES = 5

Before #26271, the resolved path is ${AppWorkPath}/${attachments.PATH} (such as /var/lib/gitea/data/attachments)
After #26271, the resolved path is ${AppDataPath}/${attachments.PATH} (such as /var/lib/gitea/data/data/attachments)

Fix #26864
Follow #26271

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 3, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2023
@delvh delvh added type/docs This PR mainly updates/creates documentation backport/v1.20 This PR should be backported to Gitea 1.20 labels Sep 3, 2023
custom/conf/app.example.ini Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 3, 2023
Co-authored-by: delvh <dev.lh@web.de>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 3, 2023
@KN4CK3R KN4CK3R merged commit 7477c93 into go-gitea:main Sep 3, 2023
24 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 3, 2023
@GiteaBot
Copy link
Contributor

GiteaBot commented Sep 3, 2023

I was unable to create a backport for 1.20. @CaiCandong, please send one manually. 🍵

go run ./contrib/backport 26883
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Sep 3, 2023
CaiCandong added a commit to CaiCandong/gitea that referenced this pull request Sep 3, 2023
This change was caused by go-gitea#26271, for configuration as below:
```
[attachment]
ENABLE = true
PATH = data/attachments
MAX_SIZE = 100
MAX_FILES = 5
```
Before go-gitea#26271, the resolved path is ${AppWorkPath}/${attachments.PATH}
(such as `/var/lib/gitea/data/attachments`)
After go-gitea#26271, the resolved path is ${AppDataPath}/${attachments.PATH}
(such as `/var/lib/gitea/data/data/attachments`)

Fix  go-gitea#26864
Follow go-gitea#26271
techknowlogick pushed a commit that referenced this pull request Sep 3, 2023
Backport #26883 
This change was caused by #26271, for configuration as below:
```
[attachment]
ENABLE = true
PATH = data/attachments
MAX_SIZE = 100
MAX_FILES = 5
```
Before #26271, the resolved path is ${AppWorkPath}/${attachments.PATH}
(such as `/var/lib/gitea/data/attachments`)
After #26271, the resolved path is ${AppDataPath}/${attachments.PATH}
(such as `/var/lib/gitea/data/data/attachments`)

Fix #26864 Follow
#26271
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 4, 2023
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Update documents to fix some links (go-gitea#26885)
  clarify aspects of the dump command (go-gitea#26887)
  Relocate the `RSS user feed` button (go-gitea#26882)
  Use Go 1.21 and update dependencies (go-gitea#26878)
  Update docs about attachment path (go-gitea#26883)
  Refactor "shortsha" (go-gitea#26877)
  Fix wrong review requested number (go-gitea#26784)
  Refactor `og:description` to limit the max length (go-gitea#26876)
  Reorder blocks in vue SFCs (go-gitea#26874)
  Make it posible to customize nav text color via css var (go-gitea#26807)
  Enable djlint H008 and fix issues (go-gitea#26869)
  Improve opengraph previews (go-gitea#26851)
  Add more descriptive error on forgot password page (go-gitea#26848)
  Allow users with write permissions for issues to add attachments with API (go-gitea#26837)
  Move licenses.txt to /assets directory (go-gitea#26866)

# Conflicts:
#	templates/base/footer_content.tmpl
@CaiCandong CaiCandong deleted the docs/updata-docs-about-storage-path branch September 4, 2023 12:41
@techknowlogick techknowlogick modified the milestones: 1.22.0, 1.21.0 Sep 5, 2023
@CaiCandong CaiCandong added the backport/done All backports for this PR have been created label Sep 6, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error downloading release files after upgrade to 1.20.3 (HTTP code 500)
5 participants