Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the DiffFileTreeItem and fix misalignment #26565

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Aug 17, 2023

Fix some layout / user-interaction problems and close #25650 , the code has been simplified (+46 −108)

image

@wxiaoguang wxiaoguang added type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Aug 17, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Aug 17, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 17, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2023
Co-authored-by: delvh <dev.lh@web.de>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 18, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 18, 2023
@silverwind silverwind enabled auto-merge (squash) August 18, 2023 19:48
@silverwind silverwind merged commit 48c4a7e into go-gitea:main Aug 18, 2023
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 18, 2023
@wxiaoguang wxiaoguang deleted the refactor-file-list branch August 19, 2023 01:23
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 19, 2023
* upstream/main:
  docs: template variables (go-gitea#26547)
  [skip ci] Updated translations via Crowdin
  Rewrite the DiffFileTreeItem and fix misalignment (go-gitea#26565)
  Allow text selection in actions step header (go-gitea#26588)
  Bump xgo to go-1.21.x and node to 20 in release-version (go-gitea#26589)
  Add minimum polyfill to support "relative-time-element" in PaleMoon (go-gitea#26575)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File tree wrong icon offset
4 participants