Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various line-height styles #26553

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Fix various line-height styles #26553

merged 3 commits into from
Aug 17, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Aug 17, 2023 •
edited
Loading

Fix #26537

Use the same default line-height as "normalize.css" instead of "1". "1" is not right because it doesn't work with descent part and causes overflow problems.

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Aug 17, 2023
@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 17, 2023
@wxiaoguang wxiaoguang mentioned this pull request Aug 17, 2023
Closed
@silverwind
Copy link
Member

Maybe normal is also a good default, but I see this 1.15 even survived into modern-normalize.

https://developer.mozilla.org/en-US/docs/Web/CSS/line-height
https://github.com/sindresorhus/modern-normalize/blob/c997a1e1d37aadbf9b6bc46ed396e7d9ebc8632f/modern-normalize.css#L29

delvh
delvh approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More CSS variables?
Yes please.
(Optimally, in the future we would only use variables and nothing else, but that's just a dream of me…)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2023
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 17, 2023
silverwind
silverwind reviewed Aug 17, 2023
View reviewed changes
web_src/css/repo.css Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 17, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 17, 2023
@silverwind silverwind enabled auto-merge (squash) August 17, 2023 21:43
@silverwind silverwind merged commit fe2b927 into go-gitea:main Aug 17, 2023
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 17, 2023
@wxiaoguang wxiaoguang deleted the fix-line-height branch August 17, 2023 23:37
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 18, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
557ecc5 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Fix various line-height styles (go-gitea#26553)
  Return empty when searching issues with no repos (go-gitea#26545)
  Support rebuilding issue indexer manually (go-gitea#26546)
  Fix label filter between `all` and `no` (go-gitea#26557)
  Fix "issueReposQueryPattern does not match query" (go-gitea#26556)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Strange green point in dashboard repo list
4 participants
@wxiaoguang @silverwind @delvh @GiteaBot