Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show Profile README when repository is private #26295

Merged
merged 9 commits into from
Aug 4, 2023

Conversation

LAX18
Copy link
Contributor

@LAX18 LAX18 commented Aug 3, 2023

As mentioned in the original thread (#23260) and in the enhancements PR #24753, this PR ensures the .profile repository is public before the README file is shown.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 3, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2023
Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure unrelated

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 3, 2023
@silverwind
Copy link
Member

CI failure is because of actions/setup-go#405.

@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 4, 2023
@lunny lunny added this to the 1.21.0 milestone Aug 4, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 4, 2023
@silverwind silverwind enabled auto-merge (squash) August 4, 2023 12:53
@silverwind silverwind merged commit 6a7a5ea into go-gitea:main Aug 4, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 4, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 6, 2023
* upstream/main: (25 commits)
  [docs] Add missing backtick in quickstart.zh-cn.md (go-gitea#26349)
  Fix incorrect CLI exit code and duplicate error message (go-gitea#26346)
  Improve CLI and messages (go-gitea#26341)
  Remove backslashed newlines on markdown (go-gitea#26344)
  Hide `last indexed SHA` when a repo could not be indexed yet (go-gitea#26340)
  Fix log typo in task.go (go-gitea#26337)
  Prevent newline errors with Debian packages (go-gitea#26332)
  Fix the bug when getting files changed for `pull_request_target` event (go-gitea#26320)
  Refactor backend SVG package and add tests (go-gitea#26335)
  Fix bug with sqlite load read (go-gitea#26305)
  Remove commit load branches and tags in wiki repo (go-gitea#26304)
  Add highlight to selected repos in milestone dashboard (go-gitea#26300)
  Do not show Profile README when repository is private (go-gitea#26295)
  Fix incorrect color of selected assignees when create issue (go-gitea#26324)
  Delete `issue_service.CreateComment` (go-gitea#26298)
  Make git batch operations use parent context timeout instead of default timeout (go-gitea#26325)
  Fix typos and grammer problems for actions documentation (go-gitea#26328)
  Update documentation for 1.21 actions (go-gitea#26317)
  Fix the wrong derive path (go-gitea#26271)
  Support getting changed files when commit ID is `EmptySHA` (go-gitea#26290)
  ...
techknowlogick pushed a commit that referenced this pull request Sep 6, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants