Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading LFS_JWT_SECRET from wrong section #26109

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Fix loading LFS_JWT_SECRET from wrong section #26109

merged 3 commits into from
Jul 25, 2023

Conversation

wolfogre
Copy link
Member

Regression of #25408.

LFS_JWT_SECRET_URI and LFS_JWT_SECRET are under the server section, not lfs.

So each time gitea restarts, it resets LFS_JWT_SECRET.

image

@wolfogre wolfogre added this to the 1.21.0 milestone Jul 25, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 25, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 25, 2023
@wxiaoguang
Copy link
Contributor

And also this one: Avoid writing config file if not installed #26107

@techknowlogick techknowlogick enabled auto-merge (squash) July 25, 2023 03:05
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 25, 2023
@techknowlogick techknowlogick merged commit 862f748 into go-gitea:main Jul 25, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 25, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wolfogre @wxiaoguang @techknowlogick @GiteaBot