Show image size on view page #25884

JakobDev · 2023-07-14T07:16:04Z

This simply shows the Image size on the view page. This is useful, if you search a image with a specific size.

silverwind · 2023-07-14T09:25:16Z

Given the style of these file infos, they don't had a label so far, so I think just 32x32 would be better.

routers/web/repo/view.go

JakobDev · 2023-07-14T10:43:24Z

Given the style of these file infos, they don't had a label so far, so I think just 32x32 would be better.

I just want to make this clear, that these numbers are the size of the image, so nobody is confused. On things like 1.0 KiB everyone knows what this mean.

silverwind · 2023-07-14T10:49:32Z

I think it's obvious anyways. We could add label tooltips to these items if we really want to show a label.

JakobDev · 2023-07-14T12:28:29Z

I think it's obvious anyways.

I'm not sure if that's obvious for anybody. I think explicit is better than implicit.

We could add label tooltips to these items if we really want to show a label.

This is the only entry in this list that has a Popup, so this would maybe be a little weird.

silverwind · 2023-07-14T12:59:26Z

This is the only entry in this list that has a Popup, so this would maybe be a little weird.

We can add label tooltips to all of them. I could likely push that into this PR.

silverwind · 2023-07-14T13:00:28Z

Also "Size" is ambiguous anyways as we have two sizes: image size and file size.

delvh · 2023-07-14T13:57:08Z

Please run make fmt

JakobDev · 2023-07-14T14:48:44Z

We can add label tooltips to all of them. I could likely push that into this PR.

You can do that, if you want, but I thnk adding Tooltips for others is a bit out of touch for this PR.

Also "Size" is ambiguous anyways as we have two sizes: image size and file size.

Fair point. So it's better to use image size.

Please run make fmt

Done

mrsdizzie · 2023-07-14T15:57:33Z

If there is a label / tooltip it should use Dimensions and not Size when referring to pixels (which also removes any ambiguity around what size)

denyskon

I think this approach is nice - we just need to take a look at that file header on mobile....

techknowlogick

blocking per @mrsdizzie's suggestion of using Dimension vs Size

silverwind · 2023-07-16T14:25:51Z

I still prefer it without a label, it just does not fit to add a label in a list that is only values. Take for example code header, no labels anywhere:

2 lines | 19 B | Plaintext

JakobDev · 2023-07-16T17:07:31Z

It says 2 lines and not just 2.

silverwind · 2023-07-17T23:32:10Z

By that notion, you would have to put "pixels", but it's a silly discussion.

denyskon · 2023-07-18T11:06:56Z

Let's just say 1920x1080 px, that should be clear to everyone.

JakobDev · 2023-07-18T14:57:05Z

I would agree with px. Did this need a translation?

denyskon · 2023-07-18T15:40:13Z

I don't think so....

puni9869 · 2023-07-24T20:42:08Z

routers/web/repo/view.go

+		if err == nil {
+			// There are Image formats go can't decode
+			// Instead of throwing an error in that case, we show the size only when we can decode
+			ctx.Data["ImageSize"] = fmt.Sprintf("%dx%dpx", img.Width, img.Height)


why ' !fInfo.st.IsSvgImage()' not svg?

svg is text-based instead of binary, and vector-based instead of line-by-line, so it doesn't really have a "size".
It is only limited by the view box that can be arbitrarily scaled.

Not entirely correct. SVGs can have height and width, and if they are absent, the size of the viewport is used IIRC. If even that is absent, browser will use 300×150 IIRC. Still I guess it's enough if this PR handles only raster images for now.

denyskon · 2023-07-26T19:46:58Z

@silverwind & @techknowlogick

Would you agree with px? If so, could we unblock this PR?

silverwind · 2023-07-30T23:26:29Z

1920x1080px seems better than with the "Image Size: " prefix, yes.

Dismiss my stale review

* upstream/main: (26 commits) Add 'Show on a map' button to Location in profile, fix layout (go-gitea#26214) Use shared template for webhook icons (go-gitea#26242) Reduce margins on user settings page, introduce `flex-container` (go-gitea#26046) Refactor and enhance issue indexer to support both searching, filtering and paging (go-gitea#26012) Show image size on view page (go-gitea#25884) Fix pull request check list is limited (go-gitea#26179) Fix API leaking Usermail if not logged in (go-gitea#25097) [skip ci] Updated licenses and gitignores Fix typo in metadata (go-gitea#26207) Update js and py dependencies (go-gitea#26243) De-emphasize issue sidebar buttons (go-gitea#26171) Don't autosize textarea in diff view (go-gitea#26233) Add `/public/assets` to `.ignore` (go-gitea#26232) Fix attachment clipboard copy on insecure origin (go-gitea#26224) Fix commit compare style (go-gitea#26209) Fix unable to display individual-level project (go-gitea#26198) Fix access check for org-level project (go-gitea#26182) Fixed incorrect locale references (go-gitea#26218) Use calendar icon for `Joined on...` in profiles (go-gitea#26215) Add changelog for 1.20.2 (go-gitea#26208) ...

Show image size on view page

e60808a

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 14, 2023

pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2023

lunny added the topic/ui Change the appearance of the Gitea UI label Jul 14, 2023

lunny added this to the 1.21.0 milestone Jul 14, 2023

delvh reviewed Jul 14, 2023

View reviewed changes

routers/web/repo/view.go Outdated Show resolved Hide resolved

routers/web/repo/view.go Outdated Show resolved Hide resolved

Add comments to import

5bcf5d3

delvh approved these changes Jul 14, 2023

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 14, 2023

Run make fmt

9e0a7f3

denyskon approved these changes Jul 14, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2023

techknowlogick previously requested changes Jul 15, 2023

View reviewed changes

GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Jul 15, 2023

puni9869 approved these changes Jul 18, 2023

View reviewed changes

JakobDev added 2 commits July 24, 2023 16:18

Merge branch 'main' into showsize

8d4fb39

Use px as text

ccb322d

puni9869 reviewed Jul 24, 2023

View reviewed changes

denyskon approved these changes Jul 24, 2023

View reviewed changes

denyskon requested a review from techknowlogick July 29, 2023 22:02

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Jul 29, 2023

denyskon requested a review from silverwind July 29, 2023 22:03

silverwind approved these changes Jul 30, 2023

View reviewed changes

silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 30, 2023

silverwind enabled auto-merge (squash) July 30, 2023 23:30

Merge branch 'main' into showsize

4b46302

GiteaBot added 3 commits July 31, 2023 08:51

Merge branch 'main' into showsize

169f4c5

Merge branch 'main' into showsize

d1dbbac

Merge branch 'main' into showsize

ced838d

silverwind merged commit aba9096 into go-gitea:main Jul 31, 2023
23 checks passed

JakobDev deleted the showsize branch July 31, 2023 06:06

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 31, 2023

go-gitea locked as resolved and limited conversation to collaborators Oct 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show image size on view page #25884

Show image size on view page #25884

JakobDev commented Jul 14, 2023

silverwind commented Jul 14, 2023

JakobDev commented Jul 14, 2023 •

edited

Loading

silverwind commented Jul 14, 2023

JakobDev commented Jul 14, 2023

silverwind commented Jul 14, 2023 •

edited

Loading

silverwind commented Jul 14, 2023 •

edited

Loading

delvh commented Jul 14, 2023

JakobDev commented Jul 14, 2023

mrsdizzie commented Jul 14, 2023

denyskon left a comment

techknowlogick left a comment

silverwind commented Jul 16, 2023 •

edited

Loading

JakobDev commented Jul 16, 2023

silverwind commented Jul 17, 2023

denyskon commented Jul 18, 2023

JakobDev commented Jul 18, 2023

denyskon commented Jul 18, 2023

puni9869 Jul 24, 2023

delvh Jul 24, 2023

silverwind Jul 30, 2023

denyskon commented Jul 26, 2023

silverwind commented Jul 30, 2023 •

edited

Loading

Show image size on view page #25884

Show image size on view page #25884

Conversation

JakobDev commented Jul 14, 2023

silverwind commented Jul 14, 2023

JakobDev commented Jul 14, 2023 • edited Loading

silverwind commented Jul 14, 2023

JakobDev commented Jul 14, 2023

silverwind commented Jul 14, 2023 • edited Loading

silverwind commented Jul 14, 2023 • edited Loading

delvh commented Jul 14, 2023

JakobDev commented Jul 14, 2023

mrsdizzie commented Jul 14, 2023

denyskon left a comment

Choose a reason for hiding this comment

techknowlogick left a comment

Choose a reason for hiding this comment

silverwind commented Jul 16, 2023 • edited Loading

JakobDev commented Jul 16, 2023

silverwind commented Jul 17, 2023

denyskon commented Jul 18, 2023

JakobDev commented Jul 18, 2023

denyskon commented Jul 18, 2023

puni9869 Jul 24, 2023

Choose a reason for hiding this comment

delvh Jul 24, 2023

Choose a reason for hiding this comment

silverwind Jul 30, 2023

Choose a reason for hiding this comment

denyskon commented Jul 26, 2023

silverwind commented Jul 30, 2023 • edited Loading

JakobDev commented Jul 14, 2023 •

edited

Loading

silverwind commented Jul 14, 2023 •

edited

Loading

silverwind commented Jul 14, 2023 •

edited

Loading

silverwind commented Jul 16, 2023 •

edited

Loading

silverwind commented Jul 30, 2023 •

edited

Loading