Don't stack PR tab menu on small screens #25789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the stacking takes up screen space - display the tabs as the navigation bar. github uses the same layout.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
lafriks
approved these changes
Jul 9, 2023
GiteaBot
added
lgtm/need 1
denyskon
suggested changes
Jul 9, 2023
There was a problem hiding this comment.
Could you please do it in the CSS file?
Line 750 in be23b73
GiteaBot
added
lgtm/blocked
sorry - not sure what I should do in the CSS file? |
|
Please set overflow-x: auto;
overflow-y: hidden;inside the existing CSS class for |
|
I am afraid this change is not right on desktop view. IIRC the "bottom line" of the menu would be broken |
pull-request-size
bot
added
size/M
Good catch - i've now added a divider below and fixed layout for large screens. Screenshots in PR description are updated. diff ignoring whitespace change: |
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Jul 10, 2023
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
lunny
approved these changes
Jul 14, 2023
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 14, 2023
* giteaofficial/main: Fix incorrect release count (go-gitea#25879) Add Github related extensions in devcontainer (go-gitea#25800) Add error info if no user can fork the repo (go-gitea#25820) Fix wrong usage of PathEscapeSegments in branch list page (go-gitea#25864) fix incorrect repo url when changed the case of ownername (go-gitea#25733) Upgrade go dependencies (go-gitea#25819) Don't stack PR tab menu on small screens (go-gitea#25789) Link to list of vulnerabilities (go-gitea#25872) [skip ci] Updated translations via Crowdin move issue filters to shared template (go-gitea#25729) [skip ci] Updated translations via Crowdin Remove `git.FileBlame` (go-gitea#25841) Fix empty project displayed in issue sidebar (go-gitea#25802) Update blog links (go-gitea#25843) Fix margin on the `new/edit milestone` page (go-gitea#25801) Do not "guess" the file encoding/BOM when using API to upload files (go-gitea#25828)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the stacking takes up screen space - display the tabs as the navigation bar. github uses the same layout.
Screenshots (left before, right after):
Large screen: