Adjust line-height on dashboard sidebar #25600
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
GiteaBot
added
lgtm/need 1
|
Very likely that this is an issue elsewhere. I will check for a more general solution but it will be a bit hacky regardless. |
| padding-top: 8.9px; /* adjust for increased line-height */ | ||
| padding-bottom: 8.9px; /* adjust for increased line-height */ |
There was a problem hiding this comment.
I have seen similar code before (and removed some of them)
IMO it's better to avoid such "fine-tuning", it seems pretty hacky.
There was a problem hiding this comment.
Does this .1px really have a visible impact? I'd say 9px or even 8px should be okay
There was a problem hiding this comment.
The impact is quite big actually: padding difference is n * 2, e.g. for list of 10 items, 0.1px padding difference will be off by 2 pixels. This is caused by fomantic using some weird calculated padding like 0.912561em. We could theoretically alter the fomantic base styles so the padding is only integer pixels.
GiteaBot
added
lgtm/need 2
|
Replaced by #26354. |
Fixes: #25597
This is caused by some unintended interaction between our
overflow: hiddenfor ellipsis and fomantic settingline-height: 1and this is the best I could come up with. Element height is unchanged after this via careful padding adjustment.Also, I found some untranslated text.