Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more unused Fomantic variants (#25292) #25323

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Remove more unused Fomantic variants (#25292) #25323

merged 1 commit into from
Jun 17, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #25292 by @silverwind

Save another 50KB of CSS by removing unused and useless Fomantic variants.

Removed the last instance of a tertiary button and fixed a TODO:

Screenshot 2023-06-15 at 22 34 36

@silverwind @GiteaBot
Remove more unused Fomantic variants (go-gitea#25292)
4a8465f 
Save another 50KB of CSS by removing unused and useless Fomantic
variants.

Removed the last instance if a `tertiary` button and fixed a TODO:

<img width="509" alt="Screenshot 2023-06-15 at 22 34 36"
src="https://github.com/go-gitea/gitea/assets/115237/8a16ae7b-2b17-439b-a096-60a52724e3d6">
@GiteaBot GiteaBot added performance/speed performance issues with slow downs skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 17, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 17, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 17, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 17, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 17, 2023
@silverwind silverwind merged commit e5629d9 into go-gitea:release/v1.20 Jun 17, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 17, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh Awaiting requested review from delvh

@yardenshoham yardenshoham Awaiting requested review from yardenshoham

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @lunny @silverwind