Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve issue search #2387

Merged
merged 5 commits into from
Sep 16, 2017
Merged

Improve issue search #2387

merged 5 commits into from
Sep 16, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Aug 25, 2017

Make improvements to issue search: (see #530 (review))

  • Add support for searching comment contents
  • Add unicode normalization and tokenization
  • Move indexer specific code out of models and into a separate module (where it can potentially be reused in the future)
  • Update bleve dependency
  • Add integration tests for issue search

Don't let the big add/removal figures scare you; that's because of the updated dependency

@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 25, 2017
@lunny lunny added this to the 1.x.x milestone Aug 25, 2017
@lunny lunny modified the milestones: 1.3.0, 1.x.x Aug 30, 2017
@lunny
Copy link
Member

lunny commented Aug 30, 2017

It seems new issue on sqlite wasn't indexed.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 30, 2017
@ethantkoenig
Copy link
Member Author

@lunny Fixed

@codecov-io
Copy link

codecov-io commented Sep 16, 2017

Codecov Report

Merging #2387 into master will increase coverage by 0.1%.
The diff coverage is 30%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2387     +/-   ##
=========================================
+ Coverage   26.86%   26.96%   +0.1%     
=========================================
  Files          84       84             
  Lines       16936    16906     -30     
=========================================
+ Hits         4550     4559      +9     
+ Misses      11712    11672     -40     
- Partials      674      675      +1
Impacted Files Coverage Δ
models/pull.go 20.2% <0%> (-0.06%) ⬇️
models/issue_indexer.go 9.67% <17.64%> (+6.13%) ⬆️
models/issue_comment.go 31.1% <21.05%> (-0.42%) ⬇️
models/issue.go 24.95% <73.33%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e11b2...503a0dc. Read the comment docs.

@lunny
Copy link
Member

lunny commented Sep 16, 2017

LGTM

@@ -10,6 +10,9 @@ PASSWD = {{TEST_PGSQL_PASSWORD}}
SSL_MODE = disable
PATH = data/gitea.db

[indexer]
ISSUE_INDEXER_PATH = integrations/indexers/issues.bleve
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use same path for mysql, pgsql and sqlite as they will conflict when run in parallel

@ethantkoenig
Copy link
Member Author

@lafriks Good catch, fixed

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 16, 2017
@lafriks
Copy link
Member

lafriks commented Sep 16, 2017

Would be great if these directories would also be added to make clean but otherwise LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 16, 2017
@lafriks
Copy link
Member

lafriks commented Sep 16, 2017

make LG-TM work

@lafriks lafriks merged commit b0f7457 into go-gitea:master Sep 16, 2017
@ethantkoenig ethantkoenig deleted the issue_indexer branch September 17, 2017 02:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants