Fix some broken css

[wxiaoguang]

1. The "close" inside "modal" are likely broken for long time
   • There is no var called --body-color
   • There is no fullscreen modal
   • The .ui.modal > .close.inside doesn't seem to match most icons. It only matches a few like "fork-repo-modal" or "adopt repo". Other places are just buggy code copied again and again.
2. Convert the legacy &:hover LESS syntax to CSS syntax

[silverwind]

There is no var called --body-color

We need a linter rule for undefined vars 😉

[silverwind]

Should try https://github.com/csstools/stylelint-value-no-unknown-custom-properties.

[codecov-commenter]

Codecov Report

Merging #23560 (39c99a2) into main (f521e88) will decrease coverage by 0.42%.
The diff coverage is 44.34%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #23560      +/-   ##
==========================================
- Coverage   47.14%   46.72%   -0.42%     
==========================================
  Files        1149     1154       +5     
  Lines      151446   152264     +818     
==========================================
- Hits        71397    71150     -247     
- Misses      71611    72653    +1042     
- Partials     8438     8461      +23     

Impacted Files	Coverage Δ
cmd/dump.go	0.67% <0.00%> (ø)
cmd/web.go	0.00% <0.00%> (ø)
models/actions/run.go	1.64% <0.00%> (-0.08%)	⬇️
models/packages/package.go	45.45% <0.00%> (-1.13%)	⬇️
models/user/search.go	77.50% <0.00%> (-6.29%)	⬇️
modules/actions/github.go	0.00% <0.00%> (ø)
modules/actions/workflows.go	0.00% <0.00%> (ø)
modules/doctor/storage.go	31.93% <0.00%> (ø)
modules/setting/git.go	45.45% <ø> (ø)
modules/storage/minio.go	1.51% <0.00%> (-0.06%)	⬇️
... and 50 more

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[silverwind]

Convert the legacy &:hover LESS syntax to CSS syntax

Thanks for catching, I recall linebuttons.css was not ran through lessc. Another option would be to just run it through it now, but I assume it will yield the same output.

[silverwind]

FYI, I tested the stylelint plugin and it works, but we need to wait on csstools/stylelint-value-no-unknown-custom-properties#32 before we can integrate it.

web_src/css/base.css
 1179:14  ✖  Unexpected custom property "--body-color" inside          csstools/value-no-unknown-custom-properties
             declaration "color".

[delvh]

🎺 🤖