Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding of empty class name (#23352) #23360

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fix adding of empty class name (#23352) #23360

merged 1 commit into from
Mar 7, 2023

Commits on Mar 7, 2023

  1. Fix adding of empty class name (go-gitea#23352) 

    This PR is to fix the error shown below. The reason is because
[`class-name`
prop](https://github.com/go-gitea/gitea/blob/main/web_src/js/components/ActionRunStatus.vue#L6)
given to `svg` component has a space, and classList cannot add empty
string.

https://user-images.githubusercontent.com/17645053/223346720-c7f9de43-5e69-4ecf-93c0-90bf04090693.mov

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
    @HesterG @lunny @GiteaBot
    2 people authored and GiteaBot committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    f040718 View commit details
    Browse the repository at this point in the history