Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cannot reopen after pushing commits to a closed PR #23189
Fix cannot reopen after pushing commits to a closed PR #23189
Changes from 2 commits
95ef3d9
fd59c8c
799fb4b
210a6ce
5f2417b
92ae573
b6f348b
cf9fea6
8f4ed45
219ffc8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've run into cases where a PR had a difference in these SHAs and so was shown as broken, even when it had never been closed. But we have not been able to get a clear repro case yet.
Maybe this test can be skipped for closed PRs, but remain for open PRs? If what's shown in the PR and what's in the head branch is not the same, I think it's important to show that to avoid accidentally merging the wrong code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey, now skip the test when only the PR is closed