Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native error checking with exec.ErrDot #22735

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

yardenshoham
Copy link
Member

This was meant to land in #22073 but was blocked until #22732 was merged

This was meant to land in go-gitea#22073 but was blocked until go-gitea#22732 was merged

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
@yardenshoham yardenshoham added this to the 1.19.0 milestone Feb 3, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 3, 2023

According to #22732 (comment), Gitea should also support to be complied with Go 1.19 . And the code should follow the go version defined in go.mod, which should also be 1.19 then.

Sorry, misread 😂

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 3, 2023
@yardenshoham
Copy link
Member Author

Yep, waiting for #22732 to get merged.

@wxiaoguang
Copy link
Contributor

Oh, sorry, I misread, I was thinking about Go 1.20 . 😂

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 3, 2023
@zeripath zeripath merged commit ce4fd95 into go-gitea:main Feb 3, 2023
@yardenshoham yardenshoham deleted the use-go1.19-error branch February 3, 2023 18:51
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 5, 2023
* giteaoffical/main: (23 commits)
  Add Cargo package registry (go-gitea#21888)
  Add new captcha: cloudflare turnstile (go-gitea#22369)
  add default user visibility to cli command "admin user create" (go-gitea#22750)
  Show all projects, not just repo projects and open/closed projects  (go-gitea#22640)
  Remove ONLY_SHOW_RELEVANT_REPOS setting (go-gitea#21962)
  Escape path for the file list (go-gitea#22741)
  Repositories: by default disable all units except code and pulls on forks (go-gitea#22541)
  Fix color of tertiary button on dark theme (go-gitea#22739)
  Refactor git command package to improve security and maintainability (go-gitea#22678)
  Improve trace logging for pulls and processes (go-gitea#22633)
  Remove 'primary' class from tab counter labels (go-gitea#22687)
  Use native error checking with `exec.ErrDot` (go-gitea#22735)
  update to build with go1.20 (go-gitea#22732)
  Add missed reverse proxy authentication documentation (go-gitea#22250)
  Update button is shown when a Pull Request is marked WIP - Issue go-gitea#21740 (go-gitea#22683)
  Do not overwrite empty DefaultBranch (go-gitea#22708)
  Improve error report when user passes a private key (go-gitea#22726)
  Add some comments for recent code (go-gitea#22725)
  Fix actions workflow branches match bug (go-gitea#22724)
  Fix group filter for ldap source sync (go-gitea#22506)
  ...
@delvh delvh added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 28, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants