Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit ambiguous character warning on rendered pages #22016

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Dec 3, 2022

The real sensitivity of ambiguous characters is in source code - therefore warning about them in rendered pages causes too many warnings. Therefore simply remove the warning on rendered pages.

The escape button will remain available and it is present on the view source page.

Fix #20999

Signed-off-by: Andrew Thornton art27@cantab.net

The real sensitivity of ambiguous characters is in source code - therefore warning about
them in rendered pages causes too many warnings. Therefore simply remove the warning
on rendered pages.

The escape button will remain available and it is present on the view source page.

Fix go-gitea#20999

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Dec 3, 2022
@zeripath zeripath added this to the 1.19.0 milestone Dec 3, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 3, 2022
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what do we do about #21841 now?
Because the problem seems related, but is also a completely different problem at the same time…

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2022
@lunny lunny merged commit 0e46499 into go-gitea:main Dec 3, 2022
@zeripath zeripath deleted the no-render-warning-on-rendered branch December 3, 2022 16:33
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 3, 2022
…2016)

Backport go-gitea#22016

The real sensitivity of ambiguous characters is in source code -
therefore warning about them in rendered pages causes too many warnings.
Therefore simply remove the warning on rendered pages.

The escape button will remain available and it is present on the view
source page.

Fix go-gitea#20999

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 3, 2022
@zeripath
Copy link
Contributor Author

zeripath commented Dec 3, 2022

@delvh see #22017

zeripath added a commit that referenced this pull request Dec 4, 2022
…22018)

Backport #22016

The real sensitivity of ambiguous characters is in source code -
therefore warning about them in rendered pages causes too many warnings.
Therefore simply remove the warning on rendered pages.

The escape button will remain available and it is present on the view
source page.

Fix #20999

Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 5, 2022
* giteaofficial/main:
  Ensure that Chinese punctuation is not ambiguous when locale is Chinese (go-gitea#22019)
  Use GhostUser if needed for TrackedTimes (go-gitea#22021)
  Add dumb-init to rootless docker (go-gitea#21775)
  On tag/branch-exist check, dont panic if repo is nil (go-gitea#21787)
  Fix ListBranches to handle empty case (go-gitea#21921)
  fix(web): reduce page jitter on browsers that support overlay scrollbar (go-gitea#21850)
  [skip ci] Updated licenses and gitignores
  Do not emit ambiguous character warning on rendered pages (go-gitea#22016)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some common characters should not be treaded as ambiguous Unicode characters
4 participants