Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token generation when using INTERNAL_TOKEN_URI (#21669) #21670

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

wxiaoguang
Copy link
Contributor

Backport #21669

Fix #21666
Caused by #19663

Before: when install, the INTERNAL_TOKEN was always generated and saved. But the internal token may be already there by INTERNAL_TOKEN_URI

After: INTERNAL_TOKEN_URI file must be non-empty. When install, skip internal token generation if the token exists.

@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Nov 3, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Nov 3, 2022
@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed backport/done All backports for this PR have been created labels Nov 3, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 3, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2022
@zeripath zeripath merged commit 89d5292 into go-gitea:release/v1.18 Nov 3, 2022
@wxiaoguang wxiaoguang deleted the backport-token branch November 5, 2022 08:48
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants