Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent invalid behavior for file reviewing when loading more files #21230

Merged
merged 9 commits into from
Sep 21, 2022
Merged

Prevent invalid behavior for file reviewing when loading more files #21230

merged 9 commits into from
Sep 21, 2022

Commits on Sep 21, 2022

  1. Prevent invalid behavior for file reviewing when loading more files 

    The problem was that later loaded files got the same ID, which confused
the browsers when clicked.

Additionally auto-update the go-licenses.json
    @delvh
    delvh committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    2736089 View commit details
    Browse the repository at this point in the history

  2. Move checkbox into the label

    @delvh
    delvh committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    7e91d95 View commit details
    Browse the repository at this point in the history

  3. use $file.NameHash instead of unstable $i

    @wxiaoguang
    wxiaoguang committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    e0813e4 View commit details
    Browse the repository at this point in the history

  4. lint

    @wxiaoguang
    wxiaoguang committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    2424b63 View commit details
    Browse the repository at this point in the history

  5. fine tune the UI

    @wxiaoguang
    wxiaoguang committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    11cb349 View commit details
    Browse the repository at this point in the history

  6. lint

    @wxiaoguang
    wxiaoguang committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    e7d56bd View commit details
    Browse the repository at this point in the history

  7. lint

    @wxiaoguang
    wxiaoguang committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    36388bc View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into no-duplicate-viewed-checkbox-ids

    @wxiaoguang
    wxiaoguang committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    ff8d114 View commit details
    Browse the repository at this point in the history

  9. fix new go fmt

    @wxiaoguang
    wxiaoguang committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    a04e7ac View commit details
    Browse the repository at this point in the history