Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missed sort bug #20996

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Fix missed sort bug #20996

merged 4 commits into from
Aug 31, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 30, 2022

Fix #20920

@lunny lunny added type/bug backport/v1.17 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 30, 2022
@lunny lunny added this to the 1.18.0 milestone Aug 30, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 30, 2022
@lunny lunny mentioned this pull request Aug 31, 2022
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Aug 31, 2022
kdumontnu
kdumontnu approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@kdumontnu kdumontnu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - fixes the issue for me 👍

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 31, 2022
@techknowlogick
Copy link
Member

ping lg-tm

@techknowlogick techknowlogick merged commit de5b8cf into go-gitea:main Aug 31, 2022
@lunny lunny deleted the lunny/fix_project_sort branch September 1, 2022 00:20
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 2, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
d823577 
* upstream/main:
  Include go.mod in gomod-check and rename to tidy-check (go-gitea#21025)
  [skip ci] Updated translations via Crowdin
  Update a few go dependencies (go-gitea#21022)
  [skip ci] Updated translations via Crowdin
  Fix missed sort bug (go-gitea#20996)
  Fix typo (go-gitea#21004)
  Make sure fmt catches all templates (go-gitea#20979)
  Remove black labels and CSS cleanup (go-gitea#21003)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdumontnu kdumontnu kdumontnu approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

Kanban cards are losing their sort/priority order in 1.17
5 participants
@lunny @techknowlogick @kdumontnu @delvh @GiteaBot