Fix i18n for email notifications #20518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/bug
skip-changelog
Gusted
approved these changes
Jul 28, 2022
GiteaBot
added
the
lgtm/need 1
delvh
reviewed
Jul 28, 2022
| @@ -59,7 +59,7 @@ | |||
| <div class="ui selection dropdown" tabindex="0"> | |||
| <input name="preference" type="hidden" value="{{.EmailNotificationsPreference}}"> | |||
| {{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
| <div class="text">{{$.locale.Tr "settings.email_notifications"}}</div> | |||
| <div class="text"></div> | |||
There was a problem hiding this comment.
Why?
Because the key doesn't exist?
And if yes, shouldn't it be created? Or what is the purpose of an empy div without a meaningful styleclass?
There was a problem hiding this comment.
The key doesn't exist.
The JS will fill the <div class=text> with selected text finally. That's how the Fomantic UI dropdown works.
6543
approved these changes
Jul 28, 2022
GiteaBot
added
lgtm/done
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #20179