Load label ID in NewLabels #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
Jun 24, 2017
models/issue_label.go
Outdated
| @@ -98,7 +98,11 @@ func (label *Label) ForegroundColor() template.CSS { | |||
|
|
|||
| // NewLabels creates new label(s) for a repository. | |||
| func NewLabels(labels ...*Label) error { | |||
| _, err := x.Insert(labels) | |||
There was a problem hiding this comment.
why not just x.Insert(labels...)?
There was a problem hiding this comment.
And of course, a transaction is needed.
There was a problem hiding this comment.
x.Insert(labels...) doesn't compile, since labels is of type []*Label, and the argument to x.Insert(..) has to be of type []interface{}.
I don't understand why is a transaction needed? From what I can tell, the call to x.Insert(..)will just generate one INSERT command.
There was a problem hiding this comment.
x.Insert(slice) is one INSERT command, x.Insert(slice...) will generate N INSERT command. A transaction for a better performance.
There was a problem hiding this comment.
Oh, I see. Updated to use a transaction.
|
LGTM |
tboerger
added
the
lgtm/need 1
ethantkoenig
force-pushed
the
fix/new_labels
branch
from
7a17f9e
to
c0b2ef7
Compare
|
Rebased to run CI again |
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in
NewLabels(..)where theIDfield for the labels were not populated. This caused a problem in thePOST /repos/:user/:repo/labelsAPI endpoint, where the response label would have an"id"attribute of 0.Also update the unit test to check that
IDhas been populated.