Fix versions check for busybox sh
#20358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
the
topic/build
`printf` in busybox emits a ugly 'invalid number' error when formatting string variables are present. Avoid that by reducing the go version check to just two digits, which ought to be enough as patch-level go versions are meant to be compatible.
silverwind
added
the
skip-changelog
silverwind
changed the title
shsh
zeripath
approved these changes
Jul 13, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Jul 14, 2022
GiteaBot
added
lgtm/done
|
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 15, 2022
* upstream/main: Fix commit status icon when in subdirectory (go-gitea#20285) Fix eslint parsing errors, remove eslint-plugin-html (go-gitea#20323) Include login_name in adminCreateUser response (go-gitea#20283) Add allow_rebase_update, default_delete_branch_after_merge to repository api response (go-gitea#20079) Allow to specify colors for text in markup (go-gitea#20363) [skip ci] Updated translations via Crowdin update xorm.io/xorm v1.3.2-0.20220714055524-c3bce556200f (go-gitea#20371) Add order by for assignee no sort issue (go-gitea#20053) Make sure `repo_dir` is an empty directory or doesn't exist before 'dump-repo' (go-gitea#20205) Fix English mistakes in some Markdown documents (go-gitea#20274) Fix versions check for busybox `sh` (go-gitea#20358)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
`printf` in busybox emits a ugly 'invalid number' error when formatting string variables are present. Avoid that by reducing the go version check to just two digits, which ought to be enough as patch-level go versions are meant to be compatible. Avoid error on node-check as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printfin busybox emits a 'invalid number' error when formatting string variables are not present. Avoid that by reducing the go version check to just two parts, which ought to be enough as patch-level go versions are meant to be compatible.Examples of such errors are seen in https://drone.gitea.io/go-gitea/gitea/57516/5/2
Showcasing the issue inside that docker container: