Keep sort when switching page

[iszla]

Keep chosen sort when browser through pages with pagination. I put the sort query parameter first, as that is how it appears in the URL when first selecting a sort type.
Fixes #1980

[bkcsoft]

It is tested on other paginated pages that doesn't have sort?

If so LGTM for now, in the future pagination should url.Parse and just retain the other variables 🙂

[iszla]

As far as I can see, it is only used where there is also sorting available. /admin/notices for example does not have sort, but does not use this template

[ethantkoenig]

@iszla It looks like templates/user/notification/notification.tmpl (GET /notifications) uses templates/base/paginate.tmpl, but does not have sorting.

[lunny]

@ethantkoenig but that will not effect notification. Only a non-use query stirng

[ethantkoenig]

@lunny Will it cause an error when the template engine tries to evaluate {{$.SortType}}? (Sorry, I'm not fluent in go templates)

[lunny]

@ethantkoenig no. it will be a empty string.

[bkcsoft]

@iszla could you test if GET /notifications crashes? (should not need anything in DB, since template should fail to compile if anything)

[iszla]

Sure thing, I'll test as soon as I get home

[iszla]

It works fine on /notifications as well. With and without pagination. Of course, when switching between pages it adds the sort query parameter but it is empty, like with the tab and q query parameters.

Example
http://localhost:3000/notifications?sort=&page=1&q=&tab=

[ethantkoenig]

LGTM