Let web and API routes have different auth methods group #19168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
lunny
force-pushed
the
lunny/smale_refactor_auth
branch
3 times, most recently
from
9f777b6
to
efe610e
Compare
delvh
reviewed
Mar 23, 2022
| webauthn.Init() | ||
| } | ||
|
|
||
| // Free should be called exactly once when the application is terminating to allow Auth plugins | ||
| // to release necessary resources | ||
| func Free() { |
There was a problem hiding this comment.
Was that simply unused, or why can't I find a replacement for it?
There was a problem hiding this comment.
Couldn't find any reference for this function. It's wired.
GiteaBot
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/smale_refactor_auth
branch
from
efe610e
to
9900b1d
Compare
Gusted
approved these changes
Mar 28, 2022
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Mar 28, 2022
GiteaBot
added
lgtm/done
|
Should use a meaningful title to merge, current title |
lunny
changed the title
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 30, 2022
* giteaoffical/main: (31 commits) Add Package Registry (go-gitea#16510) Show messages for users if the ROOT_URL is wrong, show JavaScript errors (go-gitea#18971) [skip ci] Updated translations via Crowdin Make git.OpenRepository accept Context (go-gitea#19260) Use full output of git show-ref --tags to get tags for PushUpdateAddTag (go-gitea#19235) When conflicts have been previously detected ensure that they can be resolved (go-gitea#19247) More commit info from API (go-gitea#19252) Move some issue methods as functions (go-gitea#19255) Move project files into models/project sub package (go-gitea#17704) Granular webhook events in editHook (go-gitea#19251) Provide configuration to allow camo-media proxying (go-gitea#12802) Move init repository related functions to modules (go-gitea#19159) Move organization related structs into sub package (go-gitea#18518) Refactor repo clone button and repo clone links, fix JS error on empty repo page (go-gitea#19208) Show last cron messages on monitor page (go-gitea#19223) Allow API to create file on empty repo (go-gitea#19224) Use goproxy.io instead of goproxy.cn (go-gitea#19242) New cron task: delete old system notices (go-gitea#19219) Let web and API routes have different auth methods group (go-gitea#19168) Only send webhook events to active system webhooks and only deliver to active hooks (go-gitea#19234) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web routes and API routes should have different auth methods group.