Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lfs bug #19072

Merged
merged 6 commits into from
Mar 14, 2022
Merged

Fix lfs bug #19072

merged 6 commits into from
Mar 14, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 14, 2022

No description provided.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.16 labels Mar 14, 2022
@lunny lunny added this to the 1.17.0 milestone Mar 14, 2022
KN4CK3R
KN4CK3R reviewed Mar 14, 2022
View reviewed changes
routers/web/repo/lfs.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2022
@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 14, 2022 •
edited
Loading

What does the path check fix?
Edit: Read it in Discord.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2022
Gusted
Gusted reviewed Mar 14, 2022
View reviewed changes
modules/storage/local.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2022
Gusted
Gusted reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thought of something.

modules/storage/local.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #19072 (a465347) into main (bc0d2c8) will decrease coverage by 0.00%.
The diff coverage is 23.07%.

❗ Current head a465347 differs from pull request most recent head ab8c696. Consider uploading reports for the commit ab8c696 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19072      +/-   ##
==========================================
- Coverage   46.58%   46.57%   -0.01%     
==========================================
  Files         855      855              
  Lines      122953   122979      +26     
==========================================
+ Hits        57276    57282       +6     
- Misses      58764    58776      +12     
- Partials     6913     6921       +8
Impacted Files Coverage Δ
routers/web/repo/lfs.go 0.00% <0.00%> (ø)
modules/storage/local.go 8.00% <40.00%> (+5.64%) ⬆️
modules/git/repo_base_nogogit.go 70.58% <0.00%> (-3.93%) ⬇️
modules/git/utils.go 66.29% <0.00%> (-3.38%) ⬇️
modules/log/event.go 58.13% <0.00%> (-2.44%) ⬇️
modules/process/manager.go 81.36% <0.00%> (-1.87%) ⬇️
modules/queue/queue_disk_channel.go 61.92% <0.00%> (-1.26%) ⬇️
models/issue_comment.go 51.30% <0.00%> (-1.02%) ⬇️
routers/api/v1/repo/pull.go 45.04% <0.00%> (+0.37%) ⬆️
services/pull/pull.go 40.24% <0.00%> (+0.46%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad6cf2...ab8c696. Read the comment docs.

6543 pushed a commit to 6543-forks/gitea that referenced this pull request Mar 14, 2022
@lunny @6543
Fix lfs bug (go-gitea#19072)
13e39f2
@6543 6543 mentioned this pull request Mar 14, 2022
Merged
@6543
Copy link
Member

6543 commented Mar 14, 2022

-> #19080

Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Mar 14, 2022
@lunny @6543
Fix lfs bug (go-gitea#19072)
8af36e8
@6543 6543 added the backport/done All backports for this PR have been created label Mar 14, 2022
6543 added a commit that referenced this pull request Mar 14, 2022
@6543 @lunny
Fix lfs bug (#19072) (#19080)
99861e3 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@6543 6543 merged commit 49db87a into go-gitea:main Mar 14, 2022
@lunny lunny deleted the lunny/fix_lfs_bug branch March 14, 2022 15:19
@lunny lunny added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 14, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 15, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
2329882 
* giteaofficial/main:
  Frontport Changelogs (go-gitea#19088)
  Restrict email address validation (go-gitea#17688)
  Fix lfs bug (go-gitea#19072)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Fix lfs bug (go-gitea#19072)
f3f2c1a 
* Fix lfs bug
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R left review comments

@Gusted Gusted Gusted approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @KN4CK3R @codecov-commenter @6543 @Gusted @GiteaBot