Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeds: render markdown to html #19058

Merged
merged 3 commits into from
Mar 12, 2022
Merged

Feeds: render markdown to html #19058

merged 3 commits into from
Mar 12, 2022

Conversation

noerw
Copy link
Member

@noerw noerw commented Mar 11, 2022

Issue/PR/Comment/Review content was previously emitted as raw markdown.
HTML content is supported by all atom/rss clients (and also the assumed default in Gitea's renderer).

before:
Screenshot_20220311_105622

after:
Screenshot_20220311_105509


As seen in the screenshots, Thunderbird doesn't render html in the title. Is anyone aware of RSS clients that do? If not, I'd remove HTML from the title elements in this PR as well..

edit: looks like Nextcloud News does render HTML in the title, though the link is not clickable, as the title is entirely an <a> element

@noerw noerw added the type/enhancement An improvement of existing functionality label Mar 11, 2022
@noerw noerw requested a review from 6543 March 11, 2022 09:58
@noerw noerw added this to the 1.17.0 milestone Mar 11, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 12, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19058 (7f8e9b9) into main (548adb9) will decrease coverage by 0.07%.
The diff coverage is 34.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19058      +/-   ##
==========================================
- Coverage   46.62%   46.54%   -0.08%     
==========================================
  Files         854      854              
  Lines      122587   122935     +348     
==========================================
+ Hits        57153    57222      +69     
- Misses      58537    58791     +254     
- Partials     6897     6922      +25     
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
cmd/cmd.go 40.74% <0.00%> (ø)
models/issue_comment.go 51.30% <0.00%> (-0.12%) ⬇️
models/lfs.go 21.93% <0.00%> (-0.15%) ⬇️
models/user/search.go 69.38% <ø> (ø)
modules/context/context.go 64.06% <0.00%> (ø)
modules/lfs/pointer.go 78.78% <0.00%> (-10.87%) ⬇️
modules/markup/csv/csv.go 28.28% <0.00%> (-0.59%) ⬇️
modules/markup/external/external.go 1.35% <0.00%> (-0.04%) ⬇️
modules/markup/orgmode/orgmode.go 51.88% <0.00%> (-1.00%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c043f...7f8e9b9. Read the comment docs.

@6543 6543 merged commit 9cca834 into go-gitea:main Mar 12, 2022
@6543 6543 deleted the feed-html branch March 12, 2022 22:05
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 14, 2022
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix documentation and go-gitea#19065 (go-gitea#19067)
  RSS/Atom support for Repos (go-gitea#19055)
  [skip ci] Updated licenses and gitignores
  Feeds: render markdown to html (go-gitea#19058)
  [skip ci] Updated translations via Crowdin
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* feeds: render markdown to html
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants