Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to self-request a PR review #19030

Merged
merged 4 commits into from
Mar 8, 2022
Merged

Allow users to self-request a PR review #19030

merged 4 commits into from
Mar 8, 2022

Commits on Mar 8, 2022

  1. Allow users to self-request a PR review. 

    The review request feature was added in go-gitea#10756,
where the doer got explicitly excluded from available reviewers. I don't see a
functionality or security related reason to forbid this case.

As shown by GitHubs implementation, it may be useful to self-request a review,
to be reminded oneselves about reviewing, while communicating to team mates that a
review is missing.
    @noerw
    noerw committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    281d583 View commit details
    Browse the repository at this point in the history

  2. simplify queries

    @noerw
    noerw committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    bb761de View commit details
    Browse the repository at this point in the history

  3. comment readability 

    Co-authored-by: delvh <dev.lh@web.de>
    @noerw @delvh
    noerw and delvh committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    9fc2746 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into review-selfrequest

    @6543
    6543 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    38825cd View commit details
    Browse the repository at this point in the history