Let MinUnitAccessMode return correct perm
#18675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't let `TypeExternalTracker` or `TypeExternalWiki` influence the minimal permission, as they won't be higher than read. So even if all the other ones are write, these 2 will ensure that's not higher than read. - Partially resolves go-gitea#18572 (Point 1,2,5?)
lafriks
approved these changes
Feb 8, 2022
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Feb 8, 2022
GiteaBot
added
lgtm/done
zeripath
added
backport/v1.16
type/bug
and removed
lgtm/done
|
make lgtm work |
GiteaBot
added
the
lgtm/done
|
Please send backport |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 9, 2022
* giteaofficial/main: Prevent security failure due to bad APP_ID (go-gitea#18678) [skip ci] Updated translations via Crowdin Let `MinUnitAccessMode` return correct perm (go-gitea#18675) Simplify Boost/Pause logic (go-gitea#18673) update the comparison documents (go-gitea#18669) Restart zero worker if there is still work to do (go-gitea#18658)
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Feb 9, 2022
zeripath
pushed a commit
that referenced
this pull request
Feb 9, 2022
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
- Don't let `TypeExternalTracker` or `TypeExternalWiki` influence the minimal permission, as they won't be higher than read. So even if all the other ones are write, these 2 will ensure that's not higher than read. - Partially resolves go-gitea#18572 (Point 1,2,5?) Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeExternalTrackerorTypeExternalWikiinfluence the minimal permission, as they won't be higher than read. So even if all the other ones are write, these 2 will ensure that's not higher than read.