Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments on migrated issues/prs must link to the comment ID (#18630) #18637

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Comments on migrated issues/prs must link to the comment ID (#18630) #18637

merged 2 commits into from
Feb 6, 2022

Conversation

singuliere
Copy link
Contributor

@singuliere singuliere commented Feb 6, 2022 •
edited
Loading

Instead of the issue ID which is not a valid anchor.

Backport of #18630

@singuliere
comments on migrated issues/prs must link to the comment ID
3c38e25 
Instead of the issue ID which is not a valid anchor.

Signed-off-by: singuliere <singuliere@autistici.org>
@singuliere singuliere added backport/v1.16 topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug labels Feb 6, 2022
@singuliere singuliere added this to the 1.16.2 milestone Feb 6, 2022
@zeripath zeripath modified the milestones: 1.16.2, 1.16.1 Feb 6, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 6, 2022
@singuliere
Copy link
Contributor Author

Removing the backport/v1.16 label because it is for prs that need backporting, not for prs that are being backported.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2022
@silverwind
Copy link
Member

Removing the backport/v1.16 label because it is for prs that need backporting, not for prs that are being backported.

I understand it the other way around, so the backport tags are for the main PR, and the backports themselves are untagged.

@lunny lunny merged commit fabc0ad into go-gitea:release/v1.16 Feb 6, 2022
@zeripath zeripath changed the title comments on migrated issues/prs must link to the comment ID (#18630) Comments on migrated issues/prs must link to the comment ID (#18630) Feb 6, 2022
@singuliere
Copy link
Contributor Author

Removing the backport/v1.16 label because it is for prs that need backporting, not for prs that are being backported.

I understand it the other way around, so the backport tags are for the main PR, and the backports themselves are untagged.

That's what I tried to write down but in a complicated and unclear way. Thanks for making it clearer.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug
Projects
None yet
Milestone
1.16.1
Development

Successfully merging this pull request may close these issues.
5 participants
@singuliere @silverwind @lunny @zeripath @GiteaBot