Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop logging an error when notes are not found #18626

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 5, 2022

This is an unnecessary logging event.

Fix #18616

Signed-off-by: Andrew Thornton art27@cantab.net

This is an unnecessary logging event.

Fix go-gitea#18616

Signed-off-by: Andrew Thornton <art27@cantab.net>
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@a51d211). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18626   +/-   ##
=======================================
  Coverage        ?   46.33%           
=======================================
  Files           ?      846           
  Lines           ?   121194           
  Branches        ?        0           
=======================================
  Hits            ?    56154           
  Misses          ?    58235           
  Partials        ?     6805           
Impacted Files Coverage Δ
modules/git/notes_nogogit.go 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51d211...22b2b4d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 5, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2022
@lunny lunny merged commit 9419dd2 into go-gitea:main Feb 6, 2022
@lunny
Copy link
Member

lunny commented Feb 6, 2022

Please send backport

zeripath added a commit to zeripath/gitea that referenced this pull request Feb 6, 2022
Backport go-gitea#18626

This is an unnecessary logging event.

Fix go-gitea#18616

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 6, 2022
@zeripath zeripath deleted the fix-18616-stop-logging-error-when-notes-not-found branch February 6, 2022 08:51
zeripath added a commit that referenced this pull request Feb 6, 2022
Backport #18626

This is an unnecessary logging event.

Fix #18616

Signed-off-by: Andrew Thornton <art27@cantab.net>
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
This is an unnecessary logging event.

Fix go-gitea#18616

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetNote() errors after upgrade to rel-1.16rc1
5 participants