Fix non-ASCII search on database #18437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2022 02:14
- Use `ToASCIIUpper` for SQLite database on issues search, this because `UPPER(x)` on SQLite only transforms ASCII letters. - Resolves go-gitea#18429
silverwind
reviewed
Jan 28, 2022
modules/strings/strings.go
Outdated
| ) | ||
|
|
||
| // ToASCIIUpper returns s with all ASCII letters mapped to their upper case. | ||
| func ToASCIIUpper(s string) string { |
There was a problem hiding this comment.
Nothing in golang's stdlib for this?
There was a problem hiding this comment.
Unfortunately not, the closes things is ToUpperSpecial, but the struct that is passed is more or less magic to me and has a unexported field. This function is a modification from ToUpper with the same test cases.
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Jan 29, 2022
GiteaBot
added
lgtm/need 1
|
It's fine to me and I have no objection. |
wxiaoguang
reviewed
Jan 29, 2022
wxiaoguang
approved these changes
Jan 29, 2022
GiteaBot
added
lgtm/done
Yeah, this solution is "hacky" to be more inline with the usage of Sqlite... A problem is that, this isn't the only usage of |
wxiaoguang
approved these changes
Feb 1, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 2, 2022
* giteaofficial/main: (37 commits) Collaborator trust model should trust collaborators (go-gitea#18539) Detect conflicts with 3way merge (go-gitea#18536) [skip ci] Updated translations via Crowdin Update 1.16.0 changelog to set go-gitea#17846 as breaking (go-gitea#18533) In docker rootless use $GITEA_APP_INI if provided (go-gitea#18524) revert to node14 for snapcraft Add `GetUserTeams` (go-gitea#18499) Fix review excerpt (go-gitea#18502) Update JS dependencies, fix lint (go-gitea#18389) add test coverage for original author conversion during migrations (go-gitea#18506) add gitea-fmt back (go-gitea#18526) Fix non-ASCII search on database (go-gitea#18437) Use "read" value for General Access (go-gitea#18496) Fix for AvatarURL database type (go-gitea#18487) Remove go 1.15 support (go-gitea#18511) [skip ci] Updated translations via Crowdin Use `ImagedProvider` for gplus oauth2 provider (go-gitea#18504) build with node16 in snap (go-gitea#18508) point to s3 endpoint directly (go-gitea#18497) Fix OAuth Source Edit Page (go-gitea#18495) ...
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Use `ToASCIIUpper` for SQLite database on issues search, this because `UPPER(x)` on SQLite only transforms ASCII letters. Resolves go-gitea#18429
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToASCIIUpperfor SQLite database on issues search, this becauseUPPER(x)on SQLite only transforms ASCII letters.