Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid running go vet twice #18059

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Avoid running go vet twice #18059

merged 1 commit into from
Dec 21, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Dec 21, 2021 •
edited
Loading

  • go vet is already ran by golangci-lint as linter(and must faster). make vet will only run gitea-vet(which is as fast as revivie).
  • Thanks for @zeripath for pointing out slow linting.

Avoid running go vet twice
1349ddb 
- go vet is already ran by golangci-lint as linter(and must faster).
`make vet` will only run gitea-vet(which is as fast as revivie).
- Thanks for @zeripath for pointing out slow linting.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 21, 2021
@techknowlogick techknowlogick merged commit 7be82f4 into go-gitea:main Dec 21, 2021
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 21, 2021
@Gusted Gusted deleted the double-git-vet branch December 21, 2021 18:35
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Avoid running go vet twice (go-gitea#18059)
0162195
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gusted @techknowlogick @zeripath @jolheiser @GiteaBot