Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug on detect issue/comment writer #17591

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fix bug on detect issue/comment writer #17591

merged 1 commit into from
Nov 9, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 9, 2021

As title.

@lunny lunny mentioned this pull request Nov 9, 2021
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 9, 2021
@lunny lunny mentioned this pull request Nov 9, 2021
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 9, 2021
@wxiaoguang wxiaoguang merged commit 03de593 into go-gitea:main Nov 9, 2021
@zeripath
Copy link
Contributor

zeripath commented Nov 9, 2021

Hmm... It's not immediately clear what commentTag is supposed to be doing. We need some comments here to explain this function and what it's supposed to be checking.

@wxiaoguang
Copy link
Contributor

@zeripath

This PR is a bug fix. Do you mean:

I always agree to add more comments to code 😊

@zeripath
Copy link
Contributor

zeripath commented Nov 9, 2021

I guess it is just not immediately obvious to me what a CommentTag is.

I see now it's a descriptor that is attached to a comment referring to the permissions that the user that made the comment currently has in the repository.

This is an unfortunate overloading of the word Tag. I would argue that this perhaps should be called a RoleDescriptor or PermissionsDescriptor.

@lunny lunny deleted the lunny/fix_writer_bug branch November 9, 2021 09:27
@lunny lunny added the backport/done All backports for this PR have been created label Nov 9, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Nov 22, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Fix bug on detect issue/comment writer (go-gitea#17591)
09d5c1e
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @zeripath @wxiaoguang @Gusted @GiteaBot