Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Escaping Improvements #17551

Merged
merged 18 commits into from
Nov 16, 2021
Merged

Multiple Escaping Improvements #17551

merged 18 commits into from
Nov 16, 2021

Commits on Nov 4, 2021

  1. Multiple Escaping Improvements 

    There are multiple places where Gitea does not properly escape URLs that it is building
and there are multiple places where it builds urls when there is already a simpler
function available to use this.

This is an extensive PR attempting to fix these issues.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    79d0129 View commit details
    Browse the repository at this point in the history

  2. Add escaping and deeper URLs into wiki 

    One of the major limitations of the wiki is that it does not currently allow a
hierarchy of folders. Here we add all of the escaping to allow this to be instituted.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    03ffce5 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. Ensure that links and titles in feeds are correctly escaped 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d563cd2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into really-escape

    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    684851b View commit details
    Browse the repository at this point in the history

  3. placate lint 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    9313c4c View commit details
    Browse the repository at this point in the history

  4. Remove EscapePound as Escape and PathEscape/PathEscapeSegments should… 

    … be used instead

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    59100b8 View commit details
    Browse the repository at this point in the history

  5. Remove last example of url building in locale 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    b96b85e View commit details
    Browse the repository at this point in the history

  6. More escaping 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    b266534 View commit details
    Browse the repository at this point in the history

  7. fix bug on parentpath 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d4c18fb View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into really-escape

    @zeripath
    zeripath committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    c519b12 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. as per review 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    4009abd View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into really-escape

    @zeripath
    zeripath committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    18c69e8 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Merge remote-tracking branch 'origin/main' into really-escape

    @zeripath
    zeripath committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    55eedb9 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Merge remote-tracking branch 'origin/main' into really-escape

    @zeripath
    zeripath committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    dfbd08f View commit details
    Browse the repository at this point in the history

  2. fix build 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    4809243 View commit details
    Browse the repository at this point in the history

  3. placate lint 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    141e0bf View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Merge remote-tracking branch 'origin/main' into really-escape

    @zeripath
    zeripath committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    e96565b View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Merge remote-tracking branch 'origin/main' into really-escape

    @zeripath
    zeripath committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    cbd5eec View commit details
    Browse the repository at this point in the history