Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to fetch git notes #16649

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Add API to fetch git notes #16649

merged 2 commits into from
Aug 11, 2021

Conversation

nitul1991
Copy link
Contributor

@nitul1991 nitul1991 commented Aug 7, 2021

This PR is the first in a series of commits related to exposing api endpoints to interact with git notes.

This first PR, simply creates an endpoint to fetch a git note corresponding to a commit.

close #15373

@nitul1991 nitul1991 marked this pull request as draft August 7, 2021 20:20
@nitul1991 nitul1991 force-pushed the issue_15373 branch 2 times, most recently from 2deca93 to 34e9621 Compare August 7, 2021 20:37
@6543 6543 added this to the 1.16.0 milestone Aug 8, 2021
@nitul1991 nitul1991 force-pushed the issue_15373 branch 3 times, most recently from 9c9a587 to c8582bd Compare August 8, 2021 18:37
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2021

Codecov Report

Merging #16649 (2e6fbae) into main (23d438f) will decrease coverage by 0.02%.
The diff coverage is 67.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16649      +/-   ##
==========================================
- Coverage   45.40%   45.37%   -0.03%     
==========================================
  Files         756      758       +2     
  Lines       85279    85230      -49     
==========================================
- Hits        38718    38674      -44     
+ Misses      40300    40292       -8     
- Partials     6261     6264       +3     
Impacted Files Coverage Δ
modules/git/notes_nogogit.go 71.42% <60.00%> (-3.58%) ⬇️
routers/api/v1/repo/notes.go 69.23% <69.23%> (ø)
routers/api/v1/api.go 78.47% <100.00%> (+0.02%) ⬆️
modules/notification/mail/mail.go 35.29% <0.00%> (-2.95%) ⬇️
services/pull/check.go 26.20% <0.00%> (-2.07%) ⬇️
routers/api/v1/repo/commits.go 54.87% <0.00%> (-1.60%) ⬇️
modules/notification/ui/ui.go 60.86% <0.00%> (-1.45%) ⬇️
models/commit_status.go 60.41% <0.00%> (-1.33%) ⬇️
routers/web/repo/commit.go 27.62% <0.00%> (-1.33%) ⬇️
models/issue_comment.go 51.40% <0.00%> (-1.18%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d438f...2e6fbae. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 8, 2021
@nitul1991 nitul1991 marked this pull request as ready for review August 8, 2021 18:53
modules/git/notes_gogit.go Outdated Show resolved Hide resolved
@6543 6543 added modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Aug 9, 2021
modules/git/notes_gogit.go Outdated Show resolved Hide resolved
modules/git/notes_nogogit.go Outdated Show resolved Hide resolved
modules/git/notes_gogit.go Outdated Show resolved Hide resolved
modules/git/notes_gogit.go Outdated Show resolved Hide resolved
modules/git/notes_gogit.go Outdated Show resolved Hide resolved
modules/git/notes_gogit.go Outdated Show resolved Hide resolved
modules/git/notes_nogogit.go Outdated Show resolved Hide resolved
modules/git/notes_nogogit.go Outdated Show resolved Hide resolved
modules/git/notes_nogogit.go Outdated Show resolved Hide resolved
modules/git/notes_nogogit.go Outdated Show resolved Hide resolved
modules/git/notes_nogogit.go Outdated Show resolved Hide resolved
@nitul1991
Copy link
Contributor Author

I've incorporated all the review comments and squashed all the commits into one meaningful commit.

modules/git/notes_gogit.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 10, 2021
@nitul1991 nitul1991 requested a review from 6543 August 10, 2021 17:30
@6543 6543 changed the title Add an api endpoint to fetch git notes (#15373) Add api endpoint to fetch git notes Aug 11, 2021
@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 11, 2021
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Aug 11, 2021
@6543
Copy link
Member

6543 commented Aug 11, 2021

🚀

@6543 6543 merged commit 2d25b7d into go-gitea:main Aug 11, 2021
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nitul1991 nitul1991 deleted the issue_15373 branch August 11, 2021 05:56
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@zeripath zeripath changed the title Add api endpoint to fetch git notes Add API to fetch git notes Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] add api access to git notes
6 participants