Retry rename on lock induced failures #16435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix go-gitea#16427 Signed-off-by: Andrew Thornton <art27@cantab.net>
|
If this PR succeeds at solving the problem we could/should include it in 1.15 |
GiteaBot
added
the
lgtm/need 2
6 tasks
lafriks
approved these changes
Jul 15, 2021
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Jul 15, 2021
GiteaBot
added
lgtm/done
This comment has been minimized.
This comment has been minimized.
techknowlogick
added
the
skip-changelog
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jul 15, 2021
Backport go-gitea#16435 Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix go-gitea#16427 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
lafriks
pushed a commit
that referenced
this pull request
Jul 15, 2021
Backport #16435 Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix #16427 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jul 16, 2021
Unfortunately go-gitea#16435 asserts the wrong error and should use os.LinkError not os.PathError. Fix go-gitea#16439 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jul 16, 2021
Backport go-gitea#16461 Unfortunately go-gitea#16435 asserts the wrong error and should use os.LinkError not os.PathError. Fix go-gitea#16439 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jul 16, 2021
Backport go-gitea#16461 Unfortunately go-gitea#16435 asserts the wrong error and should use os.LinkError not os.PathError. Fix go-gitea#16439 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
Jul 16, 2021
6543
pushed a commit
that referenced
this pull request
Jul 16, 2021
techknowlogick
pushed a commit
that referenced
this pull request
Jul 16, 2021
This was referenced Jul 18, 2021
Merged
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* Retry rename on lock induced failures Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix go-gitea#16427 Signed-off-by: Andrew Thornton <art27@cantab.net> * resolve CI fail Co-authored-by: techknowlogick <techknowlogick@gitea.io>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
Unfortunately go-gitea#16435 asserts the wrong error and should use os.LinkError not os.PathError. Fix go-gitea#16439 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to file locking on Windows it is possible for an
os.Renameto fail if the files or directories are being used elsewhere.This PR simply suggests retrying the rename again similar to how we handle the equivalent problem in
os.Remove.Fix #16427
Signed-off-by: Andrew Thornton art27@cantab.net