Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modified files list in webhooks when there is a space #16288

Merged
merged 6 commits into from
Jul 2, 2021
Merged

Fix modified files list in webhooks when there is a space #16288

merged 6 commits into from
Jul 2, 2021

Commits on Jun 28, 2021

  1. Fix modified files list in webhooks when there is a space 

    There is an unfortunate bug with GetCommitFileStatus where files with
spaces are misparsed and split at the space.

There is a second bug because modern gits detect renames meaning that
this function no longer works correctly.

There is a third bug in that merge commits don't have their modified
files detected correctly.

Fix go-gitea#15865

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    9d586b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Merge branch 'main' into fix-15865-spaces-in-webhook-filepath

    @6543
    6543 committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    c755caf View commit details
    Browse the repository at this point in the history

  2. make unit-testable 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    2e41a83 View commit details
    Browse the repository at this point in the history

  3. we don't need trees 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    f0eb6b2 View commit details
    Browse the repository at this point in the history

  4. add parsing unit test 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    24c65c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Merge branch 'main' into fix-15865-spaces-in-webhook-filepath

    @lunny
    lunny committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    5a83363 View commit details
    Browse the repository at this point in the history