Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fail2ban documentation #16286

Merged

Conversation

zeripath
Copy link
Contributor

Following the merge of #16278 we need to update the fail2ban
documentation to take account of the availability of the new
sshConnectionFailed failed authentication attempt log message.

Also add a deprecation notice regarding the previous publicKeyHandler
messages, as these may be a source of false positives.

Signed-off-by: Andrew Thornton art27@cantab.net

Following the merge of go-gitea#16278 we need to update the fail2ban
documentation to take account of the availability of the new
sshConnectionFailed failed authentication attempt log message.

Also add a deprecation notice regarding the previous publicKeyHandler
messages, as these may be a source of false positives.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 28, 2021
@zeripath zeripath added this to the 1.15.0 milestone Jun 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16286 (0e20a91) into main (f825f20) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16286      +/-   ##
==========================================
+ Coverage   45.42%   45.43%   +0.01%     
==========================================
  Files         709      709              
  Lines       83483    83483              
==========================================
+ Hits        37919    37930      +11     
+ Misses      39486    39473      -13     
- Partials     6078     6080       +2     
Impacted Files Coverage Δ
modules/queue/queue_bytefifo.go 73.96% <0.00%> (-4.74%) ⬇️
modules/queue/queue_disk.go 68.08% <0.00%> (-4.26%) ⬇️
modules/queue/workerpool.go 54.96% <0.00%> (-1.53%) ⬇️
modules/queue/unique_queue_disk_channel.go 47.26% <0.00%> (-1.37%) ⬇️
services/pull/pull.go 42.42% <0.00%> (+0.43%) ⬆️
routers/api/v1/repo/pull.go 28.74% <0.00%> (+0.59%) ⬆️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
modules/notification/mail/mail.go 38.23% <0.00%> (+1.96%) ⬆️
services/pull/check.go 28.27% <0.00%> (+2.75%) ⬆️
modules/queue/manager.go 68.36% <0.00%> (+2.82%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f825f20...0e20a91. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 28, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2021
@techknowlogick techknowlogick merged commit 2f3d3ac into go-gitea:main Jun 28, 2021
@zeripath zeripath deleted the update-fail2ban-documents-16278 branch June 29, 2021 19:24
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
Following the merge of go-gitea#16278 we need to update the fail2ban
documentation to take account of the availability of the new
sshConnectionFailed failed authentication attempt log message.

Also add a deprecation notice regarding the previous publicKeyHandler
messages, as these may be a source of false positives.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants