Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy needed resources to bin dir when run make build #139

Closed
wants to merge 1 commit into from
Closed

copy needed resources to bin dir when run make build #139

wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 11, 2016

No description provided.

@codecov-io
Copy link

Current coverage is 3.03% (diff: 100%)

Merging #139 into master will not change coverage

@@            master      #139   diff @@
========================================
  Files           33        33          
  Lines         8096      8096          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7830      7830          
  Partials        20        20

Powered by Codecov. Last update 96c9fef...c69aac7

tboerger
tboerger reviewed Nov 11, 2016
View reviewed changes
Makefile
cp -r ./templates ./bin/
cp -r ./public ./bin/
cp -r ./conf ./bin/
cp -r ./scripts ./bin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the scripts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because scripts got only stuff like init scripts included which is not required for that.

tboerger
tboerger reviewed Nov 11, 2016
View reviewed changes
Makefile
cp -r ./templates ./bin/
cp -r ./public ./bin/
cp -r ./conf ./bin/
cp -r ./scripts ./bin/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should build this one task simply into the root folder?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tboerger or build on bin and make a symbolic link on root folder. I will test here to see if works.

Copy link
Contributor

@joubertredrat joubertredrat Nov 11, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tboerger works fine with symbolic link.

dev@devel01:~/public_html/www/gitea-mine$ ln -s bin/gitea .
dev@devel01:~/public_html/www/gitea-mine$ ls -lah gitea
lrwxrwxrwx 1 dev dev 9 Nov 11 08:45 gitea -> bin/gitea
dev@devel01:~/public_html/www/gitea-mine$ ./gitea web
2016/11/11 08:46:43 [T] Custom path: /home/dev/public_html/www/gitea-mine/custom
2016/11/11 08:46:43 [T] Log path: /home/dev/public_html/www/gitea-mine/log
2016/11/11 08:46:43 [I] Gitea: Git with a cup of tea 0.9.99.0915
2016/11/11 08:46:43 [I] Build Time: 2016-11-11 10:45:11 UTC
2016/11/11 08:46:43 [I] Build Git Hash: 85b8b7f
2016/11/11 08:46:43 [I] Log Mode: File(Info)
2016/11/11 08:46:43 [I] Cache Service Enabled
2016/11/11 08:46:43 [I] Session Service Enabled
2016/11/11 08:46:43 [I] Git Version: 1.9.1
2016/11/11 08:46:43 [I] Run Mode: Production
2016/11/11 08:46:43 [T] Doing: CheckRepoStats
2016/11/11 08:46:43 [I] Listen: http://0.0.0.0:3000

@strk
Copy link
Member

strk commented Nov 11, 2016

Note that you can pass data directory via the GITEA_WORK_DIR env variable (would be saner than copying data into a bin directory)

@tboerger
Copy link
Member

I think we should just target it to the root folder instead of copying or linking.

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 11, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 11, 2016
@lunny lunny modified the milestones: 1.1.0, 1.0.0 Nov 17, 2016
@lunny
Copy link
Member Author

lunny commented Nov 17, 2016

So I close this, and please send a PR to change the target from bin to root folder. @tboerger

@lunny lunny closed this Nov 17, 2016
@tboerger tboerger added reviewed/invalid and removed type/enhancement An improvement of existing functionality labels Nov 24, 2016
@tboerger tboerger removed this from the 1.0.0 milestone Nov 24, 2016
@lunny lunny deleted the lunny/cp_resource_on_build branch April 19, 2017 05:41
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@Kasi-R @lunny
Fixed a bug where TreeEntries were getting cached, (thanks @filipnavara…
7d7fe9f 
…) (go-gitea#139)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
@delvh delvh added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed reviewed/invalid labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger left review comments

@joubertredrat joubertredrat joubertredrat left review comments

Assignees
No one assigned
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @strk @tboerger @joubertredrat @delvh