-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite pre-commit, post-commit and options hooks (fixes #1250) #1257
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0636e3e
issue #1250, replace {pre,post}-receive and update hooks with a singl…
philfry 83a4fe5
issue #1250, make script posix compilant
philfry 54329e5
v23, add migration script to update {pre,post}-receive and update hooks
philfry e9ba36b
migration: use a more common name and rename v23 to v26 to avoid conf…
philfry 74ca820
Merge branch 'master' into fix_hooks
philfry 7d88e22
gofmt'ed and added copyright header
philfry 5c81ed6
fix SyncRepositoryHooks to also sync wiki repos
philfry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bash-specific syntax (
$(cat)
) in what could be running with something else (setting.ScriptType
).Not that I understand how can Gitea possibly contains code to be run by unknown scripts, anyway the app.ini Cheat Sheet says
ScriptType
is usually bash or sh...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data=$(cat)
is not bash-specific.bash
can be run in posix mode when either invoking the script either usingsh
(sh scriptname
,sh
in shebang) or by using the switch--posix
(or usingset -o posix
in the script itself). Tried both of it, script worked fine. Even thoughmyarray=()
is a bashism.Some Debian systems might symlink
/bin/sh
to/bin/dash
(the Debian Almquist Shell), so we might want to force usingbash
in this case.Or, to make it more posix-compliant, give up on arrays:
(tested with
dash
)