Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "check" alias for testing #106

Merged
merged 2 commits into from
Nov 7, 2016
Merged

Add "check" alias for testing #106

merged 2 commits into from
Nov 7, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 7, 2016

@codecov-io
Copy link

codecov-io commented Nov 7, 2016

Current coverage is 2.24% (diff: 100%)

Merging #106 into master will not change coverage

@@            master      #106   diff @@
========================================
  Files           32        32          
  Lines         7521      7521          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           169       169          
  Misses        7335      7335          
  Partials        17        17          

Powered by Codecov. Last update 1b962ba...98effb6

@xinity xinity added the type/enhancement An improvement of existing functionality label Nov 7, 2016
@xinity xinity added this to the 1.x.x milestone Nov 7, 2016
Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also send it to go-sdk

@@ -62,6 +62,9 @@ lint:
test:
for PKG in $(PACKAGES); do go test -cover -coverprofile $$GOPATH/src/$$PKG/coverage.out $$PKG || exit 1; done;

# As for GNU Coding Standard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skip that comment, nothing anybody cares about :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is also a phony task

@tboerger
Copy link
Member

tboerger commented Nov 7, 2016

LGTM

1 similar comment
@andreynering
Copy link
Contributor

LGTM

@andreynering andreynering merged commit f430d26 into go-gitea:master Nov 7, 2016
@tboerger tboerger modified the milestones: 1.0.0, 1.x.x Nov 7, 2016
@strk strk deleted the check branch November 7, 2016 21:09
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jan 5, 2017
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants