-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] [API] Pull.API.Convert: Only try to get HeadBranch if HeadRepo exist #10029
[BugFix] [API] Pull.API.Convert: Only try to get HeadBranch if HeadRepo exist #10029
Conversation
the diff looks weard on code bloc L101-129 but I only added a if statement before witch check if |
Codecov Report
@@ Coverage Diff @@
## master #10029 +/- ##
==========================================
+ Coverage 43.37% 43.45% +0.07%
==========================================
Files 565 566 +1
Lines 78905 78987 +82
==========================================
+ Hits 34226 34321 +95
+ Misses 40469 40429 -40
- Partials 4210 4237 +27
Continue to review full report at Codecov.
|
@lunny done |
@6543 I think you could add a test append on function |
81569f1
to
3c9ef56
Compare
99eb9b2
to
7d132ed
Compare
Only a nit #10029 (comment) |
36b2286
to
71c9391
Compare
by the way should we backport this? |
@6543 please backport :) |
close #10025
credits to @jolheiser @zeripath who found the witch part of the code i had to look at :)