Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in Automatic Issue/PR Referencing in Wiki Pages after Upgrading to 1.21.2 #28526

Closed
loncardom opened this issue Dec 19, 2023 · 1 comment · Fixed by #28556
Closed

Regression in Automatic Issue/PR Referencing in Wiki Pages after Upgrading to 1.21.2 #28526

loncardom opened this issue Dec 19, 2023 · 1 comment · Fixed by #28556
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.21.3

Comments

@loncardom
Copy link

Description

After upgrading from Gitea version 1.20.5 to 1.21.2, I encountered an issue with the automatic issue and pull request referencing feature in Wiki pages. Previously, in version 1.20.5, this functionality was operating as expected. However, since the update to 1.21.2, the feature appears to be non-functional.

I was able to reproduce this issue on a test repository: https://try.gitea.io/loncardom/test/wiki/Home.

This leads me to two questions:

  1. Was this capability in Wiki pages an unintended feature in 1.20.5?
  2. Is this change in functionality from version 1.20.5 to 1.21.2 a bug, or was it an intentional removal of the feature?

It's worth noting that the official documentation does not explicitly mention Wiki pages in the context of automatic linking, yet this feature was operational in the earlier version (1.20.5).

Gitea is awesome btw.
Thanks

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Running Gitea through docker, though this issue is reproducible on try.gitea.io

Database

None
@wxiaoguang
Copy link
Contributor

A regression of

Before, the wiki content also renders #1 as an issue link.

image

@wxiaoguang wxiaoguang added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Dec 19, 2023
@wxiaoguang wxiaoguang mentioned this issue Dec 19, 2023
Merged
@lunny lunny added this to the 1.21.3 milestone Dec 19, 2023
@wxiaoguang wxiaoguang mentioned this issue Dec 20, 2023
Merged
lunny pushed a commit that referenced this issue Dec 20, 2023
@wxiaoguang
Fix the issue ref rendering for wiki (#28556)
e4a24d6 
Fix #28526, regression of 
* #26365

(although the author of #26365 has recent activities, but there is no
response for the regression, so I proposed this quick fix and keep the
fix simple to make it easier to backport to 1.21)
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Dec 20, 2023
@wxiaoguang @GiteaBot
Fix the issue ref rendering for wiki (go-gitea#28556)
7714c33 
Fix go-gitea#28526, regression of 
* go-gitea#26365

(although the author of go-gitea#26365 has recent activities, but there is no
response for the regression, so I proposed this quick fix and keep the
fix simple to make it easier to backport to 1.21)
@GiteaBot GiteaBot mentioned this issue Dec 20, 2023
Merged
wxiaoguang added a commit that referenced this issue Dec 20, 2023
@GiteaBot @wxiaoguang
Fix the issue ref rendering for wiki (#28556) (#28559)
f096635 
Backport #28556 by wxiaoguang

Fix #28526, regression of 
* #26365

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@wxiaoguang @fuxiaohei
Fix the issue ref rendering for wiki (go-gitea#28556)
62faa0c 
Fix go-gitea#28526, regression of 
* go-gitea#26365

(although the author of go-gitea#26365 has recent activities, but there is no
response for the regression, so I proposed this quick fix and keep the
fix simple to make it easier to backport to 1.21)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@wxiaoguang @silverwind
Fix the issue ref rendering for wiki (go-gitea#28556)
e3e1e03 
Fix go-gitea#28526, regression of 
* go-gitea#26365

(although the author of go-gitea#26365 has recent activities, but there is no
response for the regression, so I proposed this quick fix and keep the
fix simple to make it easier to backport to 1.21)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.21.3
Development

Successfully merging a pull request may close this issue.

Fix the issue ref rendering for wiki wxiaoguang/gitea
3 participants
@lunny @wxiaoguang @loncardom