Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkCitationFile() [E] GetBlobContent: object does not exist [id: cff-version:, rel_path: ] #28264

Closed
somera opened this issue Nov 28, 2023 · 7 comments · Fixed by #28314
Closed

checkCitationFile() [E] GetBlobContent: object does not exist [id: cff-version:, rel_path: ] #28264

somera opened this issue Nov 28, 2023 · 7 comments · Fixed by #28314
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.21.2

Comments

@somera
Copy link

somera commented Nov 28, 2023

Description

When I open a specicif mirror I get this

==> gitea.log <==
2023/11/28 18:21:14 ...ers/web/repo/view.go:716:checkCitationFile() [E] GetBlobContent: object does not exist [id: cff-version:, rel_path: ]
        /source/routers/web/repo/view.go:716 (0x256dd25)
        /source/routers/web/repo/view.go:967 (0x256f8f3)
        /source/routers/web/repo/view.go:746 (0x256dea4)
        /usr/local/go/src/reflect/value.go:596 (0x4ef806)
                Value.call: call(frametype, fn, stackArgs, uint32(frametype.Size()), uint32(abid.retOffset), uint32(frameSize), &regArgs)
        /usr/local/go/src/reflect/value.go:380 (0x4ee8d8)
                Value.Call: return v.call("Call", in)
        /source/modules/web/handler.go:166 (0x1aa451b)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:176 (0x1aa45b7)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:176 (0x1aa45b7)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:176 (0x1aa45b7)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:176 (0x1aa45b7)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:176 (0x1aa45b7)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/chain.go:31 (0x1a9b4c5)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/mux.go:444 (0x1a9e419)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:176 (0x1aa45b7)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:176 (0x1aa45b7)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:176 (0x1aa45b7)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/middleware/get_head.go:37 (0x24c3d3b)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:145 (0x1aa47c3)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:176 (0x1aa45b7)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/context/context.go:222 (0x1bb822e)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:145 (0x1aa47c3)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /go/pkg/mod/gitea.com/go-chi/session@v0.0.0-20230613035928-39541325faa3/session.go:257 (0x1b11375)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:145 (0x1aa47c3)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/mux.go:73 (0x1a9c0b5)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/mux.go:316 (0x1a9d99a)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/mux.go:444 (0x1a9e419)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/mux.go:73 (0x1a9c0b5)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/mux.go:316 (0x1a9d99a)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/mux.go:444 (0x1a9e419)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/routing/logger_manager.go:122 (0x1a9acf8)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:145 (0x1aa47c3)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x24134d3)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:145 (0x1aa47c3)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/routers/common/middleware.go:45 (0x24146f2)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:145 (0x1aa47c3)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/routers/common/middleware.go:37 (0x2414278)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:145 (0x1aa47c3)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/routers/common/middleware.go:99 (0x2413835)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /source/modules/web/handler.go:145 (0x1aa47c3)
        /usr/local/go/src/net/http/server.go:2136 (0x996948)
                HandlerFunc.ServeHTTP: f(w, r)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.10/mux.go:90 (0x1a9c074)
        /source/modules/web/route.go:175 (0x1aa5dc7)
        /usr/local/go/src/net/http/server.go:2938 (0x99962d)
                serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)
        /usr/local/go/src/net/http/server.go:2009 (0x995513)
                (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)
        /usr/local/go/src/runtime/asm_amd64.s:1650 (0x473ca0)
                goexit: BYTE    $0x90   // NOP

I can reimport the mirror. But there is a bug.

Gitea Version

1.21.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

image

Git Version

2.43.0

Operating System

Ubuntu 22.04.3 LTS x86_64

How are you running Gitea?

gitea-1.21.1-linux-amd64

Database

PostgreSQL
@somera
Copy link
Author

somera commented Nov 28, 2023

This bug should not crash whole UI.

This
image
is not workin.

I can ship to start page with
image

@yp05327
Copy link
Contributor

yp05327 commented Dec 1, 2023

Is that mirror private? If it is public, can you provide the URL?
And did you meet some failures or errors during mirroring that repo?

A strange thing is that object not found log said the id (of this object?) is cff-version:
which should be the content of that object I think.

@somera
Copy link
Author

somera commented Dec 1, 2023 •
edited
Loading

This was https://github.com/alibaba/GraphScope I mirrored it again and it works fine. I would say something goes wrong in 1.21.x gitea version. Cause it worked with 1.20.x.

@yp05327
Copy link
Contributor

yp05327 commented Dec 1, 2023

Ok, I got 500 in gitea.com too.
image
https://gitea.com/yp05327/GraphScope

@yp05327 yp05327 added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Dec 1, 2023
@somera
Copy link
Author

somera commented Dec 1, 2023

I imported it on https://try.gitea.io/ and there was no 500.

@yp05327
Copy link
Contributor

yp05327 commented Dec 1, 2023

I can randomly access without any error in my local.
So the git files are mirrored correctly, maybe there are some logic problems when reading them.

@yp05327
Copy link
Contributor

yp05327 commented Dec 1, 2023

I think this is caused by #27958.
I didn't completely remove all unnecessary codes.

@yp05327 yp05327 mentioned this issue Dec 1, 2023
Merged
@lunny lunny added this to the 1.21.2 milestone Dec 1, 2023
lunny pushed a commit that referenced this issue Dec 6, 2023
@yp05327
Fix object does not exist error when checking citation file (#28314)
ec90ee6 
Fix #28264

`DataAsync()` will be called twice.
Caused by #27958.
I'm sorry, I didn't completely remove all unnecessary codes.
@GiteaBot GiteaBot mentioned this issue Dec 6, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Dec 6, 2023
@yp05327 @GiteaBot
Fix object does not exist error when checking citation file (go-gitea…
01cc5cd 
…#28314)

Fix go-gitea#28264

`DataAsync()` will be called twice.
Caused by go-gitea#27958.
I'm sorry, I didn't completely remove all unnecessary codes.
@somera somera mentioned this issue Dec 6, 2023
Closed
lunny pushed a commit that referenced this issue Dec 6, 2023
@GiteaBot @yp05327
Fix object does not exist error when checking citation file (#28314) (#…
c5c44d0 
…28369)

Backport #28314 by @yp05327

Fix #28264

`DataAsync()` will be called twice.
Caused by #27958.
I'm sorry, I didn't completely remove all unnecessary codes.

Co-authored-by: yp05327 <576951401@qq.com>
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@yp05327 @fuxiaohei
Fix object does not exist error when checking citation file (go-gitea…
6c98e93 
…#28314)

Fix go-gitea#28264

`DataAsync()` will be called twice.
Caused by go-gitea#27958.
I'm sorry, I didn't completely remove all unnecessary codes.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@yp05327 @silverwind
Fix object does not exist error when checking citation file (go-gitea…
17d84de 
…#28314)

Fix go-gitea#28264

`DataAsync()` will be called twice.
Caused by go-gitea#27958.
I'm sorry, I didn't completely remove all unnecessary codes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.21.2
Development

Successfully merging a pull request may close this issue.

Fix object does not exist error when checking citation file yp05327/gitea
3 participants
@lunny @somera @yp05327