Dependencies only show one issue for each other repo #27722
Comments
|
I can't easily identify why this occurs. The template as well as the code to retrieve them do not place a limit on the list's length. |
|
this PR #17935 has several bugs and typos. It really should add some tests to ensure its behavior. |
colejohnson66
changed the title
|
Looking at your new PR and the linked PR, I can indeed confirm that the issue (no pun intended) is that only the first added issue for each other repository is shown. And they are shown in order of repository ID. So, for my screenshot, #15 was from repo ID 2, #856 from ID 3, and #23 from ID 4. In addition, issue #23 for repository ID 4 was actually the first to be added to the list of dependencies, but shows up last. |
|
That make much more sense. Your screenshot is strictly followed the old code logic. |
|
There is much to add to the Dependency list UI issues.
In sibling issue it indeed displays it, but I need to reference other issue there
So, to add reference to issue 26 in my first issue, I have to try referencing issue 25, it shows issue 26 in dropdown and it is done ! |
|
It is still rising questions on 1.21.0+rc2-22-g2d2a5657e As well as on It just shows some random results in dropdown , and misses required issues. |
Fix #27722 Fix #27357 Fix #25837 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too. 
Fix go-gitea#27722 Fix go-gitea#27357 Fix go-gitea#25837 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too. 
Backport #27736 by @lng2020 Fix #27722 Fix #27357 Fix #25837 Fix #28732 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too.  Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
Fix go-gitea#27722 Fix go-gitea#27357 Fix go-gitea#25837 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too. 
Fix go-gitea#27722 Fix go-gitea#27357 Fix go-gitea#25837 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too. 
Description
The "blocks/dependencies" area of issues only shows the three oldest additions to the list, even if there are more. The issue log does show there being more than three "new dependencies" being added. It appears like the code naively adds a
LIMIT 3to the database call with no regard for the real count.The entire list should be viewable, and it should be sorted differently than the order of insertion in the database.
Gitea Version
1.20.5
Can you reproduce the bug on the Gitea demo site?
Untested
Log Gist
No response
Screenshots
This screenshot shows only three issues as being blocked by the currently viewed one. The current issue actually blocks about a half-dozen. As above, these are the first three additions to the list, and appear in that order.
Git Version
No response
Operating System
No response
How are you running Gitea?
N/A
Database
MySQL/MariaDB
The text was updated successfully, but these errors were encountered: